You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2008/04/28 12:58:30 UTC

[PATCH] Modifying STATUS file

Hi,

Based on the comments from Hyrum 
(http://svn.haxx.se/dev/archive-2008-04/1207.shtml) I am attaching this patch, 
which adds a note on how to add revisions to a group in the STATUS file.

Pardon me, If I haven framed the doc appropriately, but let this patch be a 
place holder (may be for the patch manager) to remind that this has to be 
documented in the hacking.html file for clarity.

[[[
* www/hacking.html
   (): Add a note on adding revisions to a group in STATUS file based on
   comments from Hyrum - http://svn.haxx.se/dev/archive-2008-04/1207.shtml

Patch by: stylesen
Suggested by: hwright
]]]

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/

Re: [PATCH] Modifying STATUS file

Posted by Senthil Kumaran S <se...@collab.net>.
Hi Stefan,

Stefan Sperling wrote:
> On Tue, Apr 29, 2008 at 10:43:28AM +0530, Senthil Kumaran S wrote:
>> Shall I make the above changes and commit it?
> 
> +1
> 
> I've read the whole discussion, and I agree with your patch.

Committed in r30834.

Thank You.
-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Modifying STATUS file

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Apr 29, 2008 at 10:43:28AM +0530, Senthil Kumaran S wrote:
> Hi Arfrever,
> 
> Arfrever Frehtes Taifersar Arahesis wrote:
>> Also please note in the patch that some obvious fixes (which e.g. fix
>> typos in comments) don't require adding this '(rX only)'.
>> See r29998.
> 
> Shall I make the above changes and commit it?

+1

I've read the whole discussion, and I agree with your patch.

-- 
Stefan Sperling <st...@elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No

Re: [PATCH] Modifying STATUS file

Posted by Senthil Kumaran S <se...@collab.net>.
Hi Arfrever,

Arfrever Frehtes Taifersar Arahesis wrote:
> Also please note in the patch that some obvious fixes (which e.g. fix
> typos in comments) don't require adding this '(rX only)'.
> See r29998.

Shall I make the above changes and commit it?

-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Modifying STATUS file

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-04-28 Senthil Kumaran S <se...@collab.net> napisaƂ(a):
> Hi,
>
>  Based on the comments from Hyrum
> (http://svn.haxx.se/dev/archive-2008-04/1207.shtml) I am attaching this
> patch, which adds a note on how to add revisions to a group in the STATUS
> file.
>
>  Pardon me, If I haven framed the doc appropriately, but let this patch be a
> place holder (may be for the patch manager) to remind that this has to be
> documented in the hacking.html file for clarity.
>
>  [[[
>  * www/hacking.html
>   (): Add a note on adding revisions to a group in STATUS file based on

  (release-stabilization): Add a note on adding revisions to a group
in STATUS file based on

>   comments from Hyrum - http://svn.haxx.se/dev/archive-2008-04/1207.shtml
>
>  Patch by: stylesen
>  Suggested by: hwright
>  ]]]

Also please note in the patch that some obvious fixes (which e.g. fix
typos in comments) don't require adding this '(rX only)'.
See r29998.

Re: [PATCH] Modifying STATUS file

Posted by Senthil Kumaran S <se...@collab.net>.
Hi Daniel,

Daniel Shahaf wrote:
> Generally I don't track patch submissions by committers, only by
> volunteers.  Committers shouldn't need a mediator to ping their patches
> for them.

Thanks for the info :)

-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Modifying STATUS file

Posted by Daniel Shahaf <d....@daniel.shahaf.co.il>.
Senthil Kumaran S wrote on Mon, 28 Apr 2008 at 18:28 +0530:
> Hi,
> 
> Based on the comments from Hyrum
> (http://svn.haxx.se/dev/archive-2008-04/1207.shtml) I am attaching this patch,
> which adds a note on how to add revisions to a group in the STATUS file.
> 
> Pardon me, If I haven framed the doc appropriately, but let this patch be a
> place holder (may be for the patch manager)

Generally I don't track patch submissions by committers, only by
volunteers.  Committers shouldn't need a mediator to ping their patches
for them.

> to remind that this has to be
> documented in the hacking.html file for clarity.
> 
> [[[
> * www/hacking.html
>   (): Add a note on adding revisions to a group in STATUS file based on
>   comments from Hyrum - http://svn.haxx.se/dev/archive-2008-04/1207.shtml
> 
> Patch by: stylesen
> Suggested by: hwright
> ]]]
> 
> Thank You.
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org