You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/10/26 19:31:31 UTC

[kudu-CR] tablet: fix build on macOS 

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16650


Change subject: tablet: fix build on macOS
......................................................................

tablet: fix build on macOS

This fixes the following error:

../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *')
    ASSERT_OK(rs->CountLiveRows(&rs_live_rows));
                                ^~~~~~~~~~~~~

Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
---
M src/kudu/tablet/compaction-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/16650/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] tablet: fix build on macOS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 2: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:45:49 +0000
Gerrit-HasComments: No

[kudu-CR] tablet: fix build on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:

http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc@1058
PS1, Line 1058: int
nit: does it make sense to update this to be uint64_t as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:37:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] tablet: fix build on macOS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 1: Verified+1

verified manually on Mac.


-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:37:24 +0000
Gerrit-HasComments: No

[kudu-CR] tablet: fix build on macOS

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:

http://gerrit.cloudera.org:8080/#/c/16650/1/src/kudu/tablet/compaction-test.cc@1058
PS1, Line 1058: uin
> nit: does it make sense to update this to be uint64_t as well?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:39:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] tablet: fix build on macOS

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16650

to look at the new patch set (#2).

Change subject: tablet: fix build on macOS
......................................................................

tablet: fix build on macOS

This fixes the following error:

../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *')
    ASSERT_OK(rs->CountLiveRows(&rs_live_rows));
                                ^~~~~~~~~~~~~

Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
---
M src/kudu/tablet/compaction-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/16650/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] tablet: fix build on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:42:01 +0000
Gerrit-HasComments: No

[kudu-CR] tablet: fix build on macOS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 26 Oct 2020 19:32:28 +0000
Gerrit-HasComments: No

[kudu-CR] tablet: fix build on macOS

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16650 )

Change subject: tablet: fix build on macOS
......................................................................

tablet: fix build on macOS

This fixes the following error:

../../src/kudu/tablet/compaction-test.cc:1061:33: error: cannot initialize a parameter of type 'uint64_t *' (aka 'unsigned long long *') with an rvalue of type 'size_t *' (aka 'unsigned long *')
    ASSERT_OK(rs->CountLiveRows(&rs_live_rows));
                                ^~~~~~~~~~~~~

Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Reviewed-on: http://gerrit.cloudera.org:8080/16650
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/tablet/compaction-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Attila Bukor: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d65f95ba10a33a510d082237508ffde2783fbc0
Gerrit-Change-Number: 16650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)