You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/11/30 21:49:41 UTC

svn commit: r1208769 - /myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java

Author: struberg
Date: Wed Nov 30 20:49:41 2011
New Revision: 1208769

URL: http://svn.apache.org/viewvc?rev=1208769&view=rev
Log:
EXTCDI-243 add nice logging via IllegalStateException with info

if bean cannot be resolved

Modified:
    myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java

Modified: myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java?rev=1208769&r1=1208768&r2=1208769&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java (original)
+++ myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java Wed Nov 30 20:49:41 2011
@@ -30,6 +30,7 @@ import javax.enterprise.inject.spi.Exten
 import javax.naming.InitialContext;
 import javax.naming.NamingException;
 import java.lang.annotation.Annotation;
+import java.util.Arrays;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
@@ -135,6 +136,12 @@ public class BeanManagerProvider impleme
         BeanManager beanManager = getBeanManager();
         Set<Bean<?>> beans = beanManager.getBeans(type, qualifiers);
 
+        if (beans == null || beans.isEmpty())
+        {
+            throw new IllegalStateException("Could not find beans for Type=" + type
+                                            + " and qualifiers:" + Arrays.toString(qualifiers));
+        }
+
         return getReference(type, beanManager, beans);
     }
 
@@ -171,6 +178,7 @@ public class BeanManagerProvider impleme
     private <T> T getReference(Class<T> type, BeanManager beanManager, Set<Bean<?>> beans)
     {
         Bean<?> bean = beanManager.resolve(beans);
+
         CreationalContext<?> creationalContext = beanManager.createCreationalContext(bean);
 
         @SuppressWarnings({"unchecked", "UnnecessaryLocalVariable"})