You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/09 04:24:51 UTC

[GitHub] [iotdb] 23931017wu opened a new pull request, #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

23931017wu opened a new pull request, #6924:
URL: https://github.com/apache/iotdb/pull/6924

   ## Description
   
   ### After
   ![image](https://user-images.githubusercontent.com/71131924/183562570-80c2e56d-064c-48fc-add4-9a871eeef386.png)
   
   For the presentation of these indicators, if the leader of the confignode appears in the timeframe displayed by the graffana, the indicators may appear duplicated on the panel. At present, there is no good solution, which can only allow users to avoid the time of leader transformation when using it. Since the utility of this data is still greater than the cost of adjusting the grafana time frame operation that the user may have, I personally feel that it can be shown in this way for the time being.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] SpriCoder commented on pull request #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

Posted by GitBox <gi...@apache.org>.
SpriCoder commented on PR #6924:
URL: https://github.com/apache/iotdb/pull/6924#issuecomment-1210051486

   Get it, but I think the title of panel should describe the meaning of the data in this panel instead of a operation description. So may be the title can be "The status of cluster node" and set a value mapping(0 -> "unknown", 1 -> "survive"), see: https://grafana.com/docs/grafana/latest/panels/format-data/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] SpriCoder commented on pull request #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

Posted by GitBox <gi...@apache.org>.
SpriCoder commented on PR #6924:
URL: https://github.com/apache/iotdb/pull/6924#issuecomment-1209330661

   Good Job, but I have one problem that is what is the meaning of "Select the node that you want to see"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] Beyyes merged pull request #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

Posted by GitBox <gi...@apache.org>.
Beyyes merged PR #6924:
URL: https://github.com/apache/iotdb/pull/6924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] 23931017wu commented on pull request #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

Posted by GitBox <gi...@apache.org>.
23931017wu commented on PR #6924:
URL: https://github.com/apache/iotdb/pull/6924#issuecomment-1210044478

   > Good Job, but I have one problem that is what is the meaning of "Select the node that you want to see"?
   
   The reason for this title is that the metric of the survival status of nodes is to describe whether they are online in terms of 0 and 1, so if there are multiple nodes on the graph, their polylines will coincide. So if you want to observe its survival status, you need to click on the properties of the corresponding node below, so that you can display only the polyline of the selected node.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] 23931017wu commented on pull request #6924: [IOTDB-4072] Updated the ConfigNode Dashboard to add a display of node online and offline information and the distribution of leaders

Posted by GitBox <gi...@apache.org>.
23931017wu commented on PR #6924:
URL: https://github.com/apache/iotdb/pull/6924#issuecomment-1210070729

   > 
   
   
   
   > Get it, but I think the title of panel should describe the meaning of the data in this panel instead of a operation description. So may be the title can be "The status of cluster node" and set a value mapping(0 -> "unknown", 1 -> "survive"), see: https://grafana.com/docs/grafana/latest/panels/format-data/
   
   Okay, good idea ~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org