[GitHub] [airflow] ashb commented on a change in pull request #16629: Update DBApi witnh backwards compatibility note

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #16629:
URL: https://github.com/apache/airflow/pull/16629#discussion_r657915749



##########
File path: airflow/hooks/dbapi.py
##########
@@ -41,7 +41,14 @@ def connect(self, host: str, port: int, username: str, schema: str) -> Any:
         :return: the authorized connection object.
         """
 
-
+#########################################################################################
+#                                                                                       #
+#  Note! Be extra careful when changing this file. This hook is used as a base for      #
+#  a number of DBApi-related hooks and providers depend on the methods implemented      #
+#  Here. Whatever you add here, has to backwards compatible unless > <Airflow version>  #
+#  is added for providers using it.                                                     #

Review comment:
       ```suggestion
   #  here. Whatever you add here, has to backwards compatible unless                      #
   #  `>=<Airflow version>` is added to providers' requirements using the new feature      #
   ```
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org