You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by li...@apache.org on 2022/11/22 20:11:11 UTC

[arrow-adbc] branch main updated: refactor(c/driver_manager): remove unnecessary libarrow dependency (#194)

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new a1a2bee  refactor(c/driver_manager): remove unnecessary libarrow dependency (#194)
a1a2bee is described below

commit a1a2beee309ba16864f573a81c0c7605c071512a
Author: David Li <li...@gmail.com>
AuthorDate: Tue Nov 22 15:11:07 2022 -0500

    refactor(c/driver_manager): remove unnecessary libarrow dependency (#194)
---
 c/driver_manager/CMakeLists.txt              | 5 ++---
 c/driver_manager/adbc_driver_manager_test.cc | 5 -----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/c/driver_manager/CMakeLists.txt b/c/driver_manager/CMakeLists.txt
index ef64b38..461de33 100644
--- a/c/driver_manager/CMakeLists.txt
+++ b/c/driver_manager/CMakeLists.txt
@@ -47,11 +47,10 @@ endforeach()
 install(FILES "${REPOSITORY_ROOT}/adbc.h" adbc_driver_manager.h DESTINATION include)
 
 if(ADBC_BUILD_TESTS)
-  find_package(Arrow REQUIRED)
   if(ADBC_TEST_LINKAGE STREQUAL "shared")
-    set(TEST_LINK_LIBS adbc_driver_manager_shared arrow_shared)
+    set(TEST_LINK_LIBS adbc_driver_manager_shared)
   else()
-    set(TEST_LINK_LIBS adbc_driver_manager_static arrow_static)
+    set(TEST_LINK_LIBS adbc_driver_manager_static)
   endif()
 
   add_test_case(driver_manager_test
diff --git a/c/driver_manager/adbc_driver_manager_test.cc b/c/driver_manager/adbc_driver_manager_test.cc
index 121c376..67762fa 100644
--- a/c/driver_manager/adbc_driver_manager_test.cc
+++ b/c/driver_manager/adbc_driver_manager_test.cc
@@ -18,11 +18,6 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
-#include <arrow/c/bridge.h>
-#include <arrow/record_batch.h>
-#include <arrow/table.h>
-#include <arrow/testing/matchers.h>
-
 #include <memory>
 #include <string>
 #include <vector>