[GitHub] [netbeans] mbien commented on a diff in pull request #4672: Avoid using an invalid JavaPlatform

[GitBox <gi...@apache.org>]

mbien commented on code in PR #4672:
URL: https://github.com/apache/netbeans/pull/4672#discussion_r977032122


##########
java/spi.java.hints/src/org/netbeans/modules/java/hints/spiimpl/Utilities.java:
##########
@@ -1083,7 +1083,7 @@ public synchronized ClasspathInfo createUniversalCPInfo() {
             final JavaPlatformManager man = JavaPlatformManager.getDefault();
             if (select.getSpecification().getVersion() != null) {
                 for (JavaPlatform p : JavaPlatformManager.getDefault().getInstalledPlatforms()) {
-                    if (!"j2se".equals(p.getSpecification().getName()) || p.getSpecification().getVersion() == null) continue;
+                    if (!p.isValid() || !"j2se".equals(p.getSpecification().getName()) || p.getSpecification().getVersion() == null) continue;
                     if (p.getSpecification().getVersion().compareTo(select.getSpecification().getVersion()) > 0) {
                         select = p;
                     }

Review Comment:
   the fix makes sense. But I believe this whole section needs some work. 
   
   E.g if the default platform has no spec version, it would simply select the default platform without searching further?
   
   how about:
   ```java
               final JavaPlatformManager man = JavaPlatformManager.getDefault();
               JavaPlatform select = Stream.concat(Stream.of(man.getInstalledPlatforms()), Stream.of(JavaPlatform.getDefault()))
                       .filter(JavaPlatform::isValid)
                       .filter((p) -> "j2se".equals(p.getSpecification().getName()))
                       .filter((p) -> p.getSpecification().getVersion() != null)
                       .max((p1, p2) -> p1.getSpecification().getVersion().compareTo(p2.getSpecification().getVersion()))
                       .orElse(JavaPlatform.getDefault());
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists