You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/29 02:13:54 UTC
[GitHub] [kafka] showuon opened a new pull request #8750: kafka-10052: Small Refactor
showuon opened a new pull request #8750:
URL: https://github.com/apache/kafka/pull/8750
1. Remove redundant `connect.stop();` since we'll do it after each test case in `close()` function
2. Refine the error message to make it better explain the errors
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine merged pull request #8750: MINOR: Code cleanup and assertion message fixes in Connect integration tests
Posted by GitBox <gi...@apache.org>.
kkonstantine merged pull request #8750:
URL: https://github.com/apache/kafka/pull/8750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8750: kafka-10052: Small Refactor
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8750:
URL: https://github.com/apache/kafka/pull/8750#issuecomment-636415779
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #8750: kafka-10052: Small Refactor
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8750:
URL: https://github.com/apache/kafka/pull/8750#issuecomment-635717082
hi @kkonstantine , I did some investigation for this flaky errors days ago, but today, I found out you already fix it, and fix it with better way! Cool!
This is a small refactor PR. please help review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8750: MINOR: Code cleanup and assertion message fixes in Connect integration tests
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8750:
URL: https://github.com/apache/kafka/pull/8750#issuecomment-637189748
Merged to `trunk` and backported to `2.6`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org