You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 20:08:47 UTC
[GitHub] [airflow] potiuk opened a new pull request #14430: Pre-commit cache is tied to a specific python version
potiuk opened a new pull request #14430:
URL: https://github.com/apache/airflow/pull/14430
The Pre-commit cache did not work when there is a change in
version of host python version used. When python version changed
from 3.6.12 to 3.6.13, the cache rendered useless.
This change adds python versio to the cache key specification,
including fallback value also including the python version, so
that even after changing pre-commit, the cache can be rebuilt
from the last-good cache but for the same python version.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14430: Pre-commit cache is tied to a specific python version
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14430:
URL: https://github.com/apache/airflow/pull/14430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14430: Pre-commit cache is tied to a specific python version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14430:
URL: https://github.com/apache/airflow/pull/14430#issuecomment-785376216
a bit more changes needed, I realized :( Yaml rule for spaces in multiline are weird, and I forgot that we have SIX similar cases actually :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org