You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/31 02:52:03 UTC
Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-958
https://issues.apache.org/jira/browse/MESOS-958
Repository: mesos-git
Description
-------
See https://issues.apache.org/jira/browse/MESOS-958
Diffs
-----
src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
Diff: https://reviews.apache.org/r/17577/diff/
Testing
-------
make check.
Checked the log for GroupTest.GroupPathWithRestrictivePerms.
Thanks,
Jiang Yan Xu
Re: Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/#review33283
-----------------------------------------------------------
Ship it!
Also mention that we fail even if we can't do an exists() check on any of the intermediate nodes.
- Vinod Kone
On Jan. 31, 2014, 2:17 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17577/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 2:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Raul Gutierrez Segales, and Vinod Kone.
>
>
> Bugs: MESOS-958
> https://issues.apache.org/jira/browse/MESOS-958
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/MESOS-958
>
>
> Diffs
> -----
>
> src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
>
> Diff: https://reviews.apache.org/r/17577/diff/
>
>
> Testing
> -------
>
> make check.
> Checked the log for GroupTest.GroupPathWithRestrictivePerms.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/#review33893
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 31, 2014, 5:37 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17577/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 5:37 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-958
> https://issues.apache.org/jira/browse/MESOS-958
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/MESOS-958
>
>
> Diffs
> -----
>
> src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
>
> Diff: https://reviews.apache.org/r/17577/diff/
>
>
> Testing
> -------
>
> make check.
> Checked the log for GroupTest.GroupPathWithRestrictivePerms.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 9:37 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Vinod's
Bugs: MESOS-958
https://issues.apache.org/jira/browse/MESOS-958
Repository: mesos-git
Description
-------
See https://issues.apache.org/jira/browse/MESOS-958
Diffs (updated)
-----
src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
Diff: https://reviews.apache.org/r/17577/diff/
Testing
-------
make check.
Checked the log for GroupTest.GroupPathWithRestrictivePerms.
Thanks,
Jiang Yan Xu
Re: Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
Posted by Raul Gutierrez Segales <rg...@itevenworks.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/#review33287
-----------------------------------------------------------
Ship it!
Ship It!
- Raul Gutierrez Segales
On Jan. 31, 2014, 2:17 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17577/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 2:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Raul Gutierrez Segales, and Vinod Kone.
>
>
> Bugs: MESOS-958
> https://issues.apache.org/jira/browse/MESOS-958
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/MESOS-958
>
>
> Diffs
> -----
>
> src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
>
> Diff: https://reviews.apache.org/r/17577/diff/
>
>
> Testing
> -------
>
> make check.
> Checked the log for GroupTest.GroupPathWithRestrictivePerms.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 17577: Group now aborts in the face of ZNOAUTH error when
creating the parent path for the group.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17577/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 2:17 a.m.)
Review request for mesos, Benjamin Hindman, Raul Gutierrez Segales, and Vinod Kone.
Changes
-------
adding raul and benh as reviewers.
Bugs: MESOS-958
https://issues.apache.org/jira/browse/MESOS-958
Repository: mesos-git
Description
-------
See https://issues.apache.org/jira/browse/MESOS-958
Diffs
-----
src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3
Diff: https://reviews.apache.org/r/17577/diff/
Testing
-------
make check.
Checked the log for GroupTest.GroupPathWithRestrictivePerms.
Thanks,
Jiang Yan Xu