You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/20 05:03:50 UTC

[GitHub] [apisix] leslie-tsang opened a new pull request #5859: chore: improve insta

leslie-tsang opened a new pull request #5859:
URL: https://github.com/apache/apisix/pull/5859


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
   6. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5859: chore: improve installation experience

Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5859:
URL: https://github.com/apache/apisix/pull/5859#discussion_r772160019



##########
File path: utils/install-dependencies.sh
##########
@@ -26,7 +26,7 @@ function detect_aur_helper() {
         AUR_HELPER=pacaur
     else
         echo No available AUR helpers found. Please specify your AUR helper by AUR_HELPER.
-        exit -1
+        exit 1

Review comment:
       > Every command returns an exit status (sometimes referred to as a return status or exit code). A successful command returns a 0, while an unsuccessful one returns a **non-zero value** that usually can be interpreted as an error code. Well-behaved UNIX commands, programs, and utilities return a 0 exit code upon successful completion, though there are some exceptions.
   
   Ref to [shell exit-status](https://tldp.org/LDP/abs/html/exit-status.html) and [SC2242](https://github.com/koalaman/shellcheck/wiki/SC2242)
   
   IMO, We should obey `SC2242` to make it more user friendly ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5859: chore: improve installation experience

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5859:
URL: https://github.com/apache/apisix/pull/5859


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5859: chore: improve installation experience

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5859:
URL: https://github.com/apache/apisix/pull/5859#discussion_r772167803



##########
File path: utils/install-dependencies.sh
##########
@@ -26,7 +26,7 @@ function detect_aur_helper() {
         AUR_HELPER=pacaur
     else
         echo No available AUR helpers found. Please specify your AUR helper by AUR_HELPER.
-        exit -1
+        exit 1

Review comment:
       Could we use `exit 255` to be compatible with the previous code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #5859: chore: improve installation experience

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5859:
URL: https://github.com/apache/apisix/pull/5859#discussion_r772154093



##########
File path: utils/install-dependencies.sh
##########
@@ -26,7 +26,7 @@ function detect_aur_helper() {
         AUR_HELPER=pacaur
     else
         echo No available AUR helpers found. Please specify your AUR helper by AUR_HELPER.
-        exit -1
+        exit 1

Review comment:
       Why need to change the arch Linux installation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org