You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2015/07/17 09:07:27 UTC
[GitHub] activemq-artemis pull request: Fix a condition check in xaCommit()
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/85
Fix a condition check in xaCommit()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis master_fix_hang
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 0e607d1e13f237b9e8d703690abe5da7a9f14f5e
Author: Howard Gao <hg...@redhat.com>
Date: 2015-07-17T07:05:00Z
Fix a condition check in xaCommit()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix a condition check in xaCommit()
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-artemis/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix a condition check in xaCommit()
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/85#issuecomment-122934559
@andytaylor do you remember this? I think this XID was on purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix a condition check in xaCommit()
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/85#issuecomment-123166924
Yeah I think you are right clebert. I'm closing this and fix it on the test side. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix a condition check in xaCommit()
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/85#issuecomment-123126380
It could be...
I believe the issue here is on the ActiveMQ5 implementation, or on the test.. they should send an xaEnd before the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---