You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2016/07/13 23:32:38 UTC
Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work
for few cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47837/#review142151
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 405)
<https://reviews.apache.org/r/47837/#comment207668>
This code seems to be for a different issue. Can you update with details on why this change is done both in jira and here?
core/src/main/java/org/apache/oozie/lock/MemoryLocks.java (lines 41 - 42)
<https://reviews.apache.org/r/47837/#comment207673>
Add private final back
core/src/main/java/org/apache/oozie/lock/MemoryLocks.java (line 85)
<https://reviews.apache.org/r/47837/#comment207672>
Unnecessary garbage object creation. If get is null, then do putIfAbsent.
core/src/main/java/org/apache/oozie/service/MemoryLocksService.java (line 33)
<https://reviews.apache.org/r/47837/#comment207674>
protected
core/src/main/java/org/apache/oozie/service/ZKLocksService.java (lines 145 - 146)
<https://reviews.apache.org/r/47837/#comment207677>
If get is null, then putIfAbsent
core/src/main/java/org/apache/oozie/service/ZKLocksService.java (lines 169 - 170)
<https://reviews.apache.org/r/47837/#comment207684>
Add private final back
- Rohini Palaniswamy
On May 25, 2016, 6:45 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47837/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 6:45 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2501
> https://issues.apache.org/jira/browse/OOZIE-2501
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2501 ZK reentrant lock doesn't work for few cases
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 2939b604da579adeca399c879425eafab2536b88
> core/src/main/java/org/apache/oozie/lock/MemoryLocks.java 7d65ac0e24a62086732ec91fc24f89b62469451d
> core/src/main/java/org/apache/oozie/service/MemoryLocksService.java d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b
> core/src/main/java/org/apache/oozie/service/ZKLocksService.java 35fc8a6592b2ba3c5ed4a78b9cc6ed90dd417f40
> core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java 61fec19b346748b22df1b58f014c32b1c04c8c1f
> core/src/test/java/org/apache/oozie/service/TestZKLocksService.java 70aa4d7d54c286fec1858a0d0f97f09fff9b4b9f
>
> Diff: https://reviews.apache.org/r/47837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work
for few cases
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java, line 405
> > <https://reviews.apache.org/r/47837/diff/1/?file=1393788#file1393788line405>
> >
> > This code seems to be for a different issue. Can you update with details on why this change is done both in jira and here?
>
> Rohini Palaniswamy wrote:
> Can you clarify more? This code is not related to this jira. So please add information to the jira on the actual issue that is being fixed here and in the jira or move this to a separate jira. The comment in code mentions what is being fixed, but you need to mention in the jira what is the affected case scenario.
Added comment to JIRA.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47837/#review142151
-----------------------------------------------------------
On Aug. 1, 2016, 6:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47837/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2016, 6:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2501
> https://issues.apache.org/jira/browse/OOZIE-2501
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2501 ZK reentrant lock doesn't work for few cases
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 41f4430f69cb7a9b132a4000c3e5c8aa7573c0a0
> core/src/main/java/org/apache/oozie/lock/MemoryLocks.java 7d65ac0e24a62086732ec91fc24f89b62469451d
> core/src/main/java/org/apache/oozie/service/MemoryLocksService.java d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b
> core/src/main/java/org/apache/oozie/service/ZKLocksService.java 952b90d5dfbfeccf4600238f75885c792709ffc7
> core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java 61fec19b346748b22df1b58f014c32b1c04c8c1f
> core/src/test/java/org/apache/oozie/service/TestZKLocksService.java d1acadfff36fff637fb9ccb8e3feffb24248c792
>
> Diff: https://reviews.apache.org/r/47837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work
for few cases
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java, line 33
> > <https://reviews.apache.org/r/47837/diff/1/?file=1393790#file1393790line33>
> >
> > protected
It is used for MemoryLocks which is not subcalss of MemoryLocksService.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47837/#review142151
-----------------------------------------------------------
On May 25, 2016, 6:45 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47837/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 6:45 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2501
> https://issues.apache.org/jira/browse/OOZIE-2501
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2501 ZK reentrant lock doesn't work for few cases
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 2939b604da579adeca399c879425eafab2536b88
> core/src/main/java/org/apache/oozie/lock/MemoryLocks.java 7d65ac0e24a62086732ec91fc24f89b62469451d
> core/src/main/java/org/apache/oozie/service/MemoryLocksService.java d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b
> core/src/main/java/org/apache/oozie/service/ZKLocksService.java 35fc8a6592b2ba3c5ed4a78b9cc6ed90dd417f40
> core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java 61fec19b346748b22df1b58f014c32b1c04c8c1f
> core/src/test/java/org/apache/oozie/service/TestZKLocksService.java 70aa4d7d54c286fec1858a0d0f97f09fff9b4b9f
>
> Diff: https://reviews.apache.org/r/47837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work
for few cases
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java, line 405
> > <https://reviews.apache.org/r/47837/diff/1/?file=1393788#file1393788line405>
> >
> > This code seems to be for a different issue. Can you update with details on why this change is done both in jira and here?
Can you clarify more? This code is not related to this jira. So please add information to the jira on the actual issue that is being fixed here and in the jira or move this to a separate jira. The comment in code mentions what is being fixed, but you need to mention in the jira what is the affected case scenario.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47837/#review142151
-----------------------------------------------------------
On Aug. 1, 2016, 6:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47837/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2016, 6:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2501
> https://issues.apache.org/jira/browse/OOZIE-2501
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-2501 ZK reentrant lock doesn't work for few cases
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 41f4430f69cb7a9b132a4000c3e5c8aa7573c0a0
> core/src/main/java/org/apache/oozie/lock/MemoryLocks.java 7d65ac0e24a62086732ec91fc24f89b62469451d
> core/src/main/java/org/apache/oozie/service/MemoryLocksService.java d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b
> core/src/main/java/org/apache/oozie/service/ZKLocksService.java 952b90d5dfbfeccf4600238f75885c792709ffc7
> core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java 61fec19b346748b22df1b58f014c32b1c04c8c1f
> core/src/test/java/org/apache/oozie/service/TestZKLocksService.java d1acadfff36fff637fb9ccb8e3feffb24248c792
>
> Diff: https://reviews.apache.org/r/47837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>