You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Renato Marroquin <re...@gmail.com> on 2013/11/09 00:18:41 UTC
Review Request 15377: Create VertexOutputFormat to Apache Gora
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15377/
-----------------------------------------------------------
Review request for giraph and Claudio Martella.
Repository: giraph-git
Description
-------
Create VertexOutputFormat to Apache Gora
Diffs
-----
giraph-gora/conf/edge.avsc PRE-CREATION
giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
giraph-gora/conf/gora.properties PRE-CREATION
giraph-gora/conf/vertex.json PRE-CREATION
giraph-gora/conf/zoo.cfg PRE-CREATION
giraph-gora/pom.xml PRE-CREATION
giraph-gora/src/main/assembly/compile.xml PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexOutputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexOutputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertexResult.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexOutputFormat.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexOutputFormat.java PRE-CREATION
pom.xml cc2c9a8
Diff: https://reviews.apache.org/r/15377/diff/
Testing
-------
Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
Thanks,
Renato Marroquin
Re: Review Request 15377: Create VertexOutputFormat to Apache Gora
Posted by Renato Marroquin <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15377/
-----------------------------------------------------------
(Updated Nov. 18, 2013, 1:07 a.m.)
Review request for giraph and Claudio Martella.
Changes
-------
Adding changes needed.
Repository: giraph-git
Description
-------
Create VertexOutputFormat to Apache Gora
Diffs (updated)
-----
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexOutputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexOutputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertexResult.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexOutputFormat.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexOutputFormat.java PRE-CREATION
Diff: https://reviews.apache.org/r/15377/diff/
Testing
-------
Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
Thanks,
Renato Marroquin
Re: Review Request 15377: Create VertexOutputFormat to Apache Gora
Posted by Claudio Martella <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15377/#review28620
-----------------------------------------------------------
also here, some cosmetic fixes. make sure that the patches are applicable incrementally (e.g. there's no code overlap).
- Claudio Martella
On Nov. 8, 2013, 11:18 p.m., Renato Marroquin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15377/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 11:18 p.m.)
>
>
> Review request for giraph and Claudio Martella.
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> Create VertexOutputFormat to Apache Gora
>
>
> Diffs
> -----
>
> giraph-gora/conf/edge.avsc PRE-CREATION
> giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
> giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
> giraph-gora/conf/gora.properties PRE-CREATION
> giraph-gora/conf/vertex.json PRE-CREATION
> giraph-gora/conf/zoo.cfg PRE-CREATION
> giraph-gora/pom.xml PRE-CREATION
> giraph-gora/src/main/assembly/compile.xml PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertexResult.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexOutputFormat.java PRE-CREATION
> pom.xml cc2c9a8
>
> Diff: https://reviews.apache.org/r/15377/diff/
>
>
> Testing
> -------
>
> Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
>
>
> Thanks,
>
> Renato Marroquin
>
>
Re: Review Request 15377: Create VertexOutputFormat to Apache Gora
Posted by Claudio Martella <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15377/#review28619
-----------------------------------------------------------
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexOutputFormat.java
<https://reviews.apache.org/r/15377/#comment55515>
same as for the inputformat, please specify this is an example.
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java
<https://reviews.apache.org/r/15377/#comment55516>
extra space
- Claudio Martella
On Nov. 8, 2013, 11:18 p.m., Renato Marroquin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15377/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 11:18 p.m.)
>
>
> Review request for giraph and Claudio Martella.
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> Create VertexOutputFormat to Apache Gora
>
>
> Diffs
> -----
>
> giraph-gora/conf/edge.avsc PRE-CREATION
> giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
> giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
> giraph-gora/conf/gora.properties PRE-CREATION
> giraph-gora/conf/vertex.json PRE-CREATION
> giraph-gora/conf/zoo.cfg PRE-CREATION
> giraph-gora/pom.xml PRE-CREATION
> giraph-gora/src/main/assembly/compile.xml PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertexResult.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexOutputFormat.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexOutputFormat.java PRE-CREATION
> pom.xml cc2c9a8
>
> Diff: https://reviews.apache.org/r/15377/diff/
>
>
> Testing
> -------
>
> Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
>
>
> Thanks,
>
> Renato Marroquin
>
>