You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/12/15 07:22:46 UTC

[GitHub] [incubator-linkis] casionone opened a new pull request #1203: optimize the logic of tag update/delete and fix ddl bug

casionone opened a new pull request #1203:
URL: https://github.com/apache/incubator-linkis/pull/1203


   
   ### Brief change log
   
   - fix the problem of the upper limit of user concurrent tasks
   - increase the rpc method of configuration
   - fix NPE for engine plugin
   - optimize the logic of tag update and delete, and solve the problem of deleting public tags
   - add fixed EM routing
   - fix the bug of adding engine in configuration global settings
   - fix ddl bug
   
   ### Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): ( no)
   - Anything that affects deployment: (no )
   - The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
   
   ### Documentation
   - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1203: optimize the logic of tag update/delete and fix ddl bug

Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1203:
URL: https://github.com/apache/incubator-linkis/pull/1203#discussion_r769329847



##########
File path: db/linkis_ddl.sql
##########
@@ -530,7 +532,7 @@ create table if not exists linkis_ps_bml_project_user(
   `id` int(10) NOT NULL AUTO_INCREMENT,
   `project_id` int(10) NOT NULL,
   `username` varchar(64) DEFAULT NULL,
-  `priv` int(10) not null default 7,
+  `priv` int(10) not null default 7, -- rwx 421 相加, 8是管理员,可以为其他用户授权

Review comment:
       Need English




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] casionone commented on a change in pull request #1203: optimize the logic of tag update/delete and fix ddl bug

Posted by GitBox <gi...@apache.org>.
casionone commented on a change in pull request #1203:
URL: https://github.com/apache/incubator-linkis/pull/1203#discussion_r769343992



##########
File path: db/linkis_ddl.sql
##########
@@ -530,7 +532,7 @@ create table if not exists linkis_ps_bml_project_user(
   `id` int(10) NOT NULL AUTO_INCREMENT,
   `project_id` int(10) NOT NULL,
   `username` varchar(64) DEFAULT NULL,
-  `priv` int(10) not null default 7,
+  `priv` int(10) not null default 7, -- rwx 421 相加, 8是管理员,可以为其他用户授权

Review comment:
       ok I will fix it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong merged pull request #1203: optimize the logic of tag update/delete and fix ddl bug

Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1203:
URL: https://github.com/apache/incubator-linkis/pull/1203


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org