You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 19:12:24 UTC
[GitHub] [airflow] AndrewShakinovsky-SAS opened a new pull request, #28503: Initial support for SAS community provider
AndrewShakinovsky-SAS opened a new pull request, #28503:
URL: https://github.com/apache/airflow/pull/28503
Initial support for SAS community provider
Adds:
SAS Studio Flow Operator
SAS Job Execution Operator
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AndrewShakinovsky-SAS commented on pull request #28503: Initial support for SAS community provider
Posted by GitBox <gi...@apache.org>.
AndrewShakinovsky-SAS commented on PR #28503:
URL: https://github.com/apache/airflow/pull/28503#issuecomment-1360041558
@potiuk @XD-DENG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #28503: Initial support for SAS community provider
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #28503:
URL: https://github.com/apache/airflow/pull/28503#discussion_r1053732522
##########
airflow/providers/sas/_utils/logon.py:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import base64
+import urllib.parse
+
+import requests
+import urllib3
+from urllib3.exceptions import InsecureRequestWarning
+
+from airflow.hooks.base import BaseHook
+
+
+def create_session_for_connection(connection_name: str):
+ print(f"Creating session for connection named {connection_name}")
Review Comment:
We use Hooks for this purpose: https://airflow.apache.org/docs/apache-airflow/stable/concepts/connections.html#hooks which is also provide nice ability to create Connection into the UI: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#custom-connection-types
##########
airflow/providers/sas/_utils/logon.py:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import base64
+import urllib.parse
+
+import requests
+import urllib3
+from urllib3.exceptions import InsecureRequestWarning
+
+from airflow.hooks.base import BaseHook
+
+
+def create_session_for_connection(connection_name: str):
+ print(f"Creating session for connection named {connection_name}")
+
+ # disable insecure HTTP requests warnings
+ urllib3.disable_warnings(InsecureRequestWarning)
Review Comment:
Hmm.. is this globally disable all `InsecureRequestWarning`?
##########
airflow/providers/sas/operators/sas_jobexecution.py:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+from __future__ import annotations
+
+import urllib.parse
+
+from airflow.exceptions import AirflowFailException
+from airflow.models import BaseOperator
+from airflow.providers.sas._utils.logon import create_session_for_connection
+
+JES_URI = "/jobExecution"
+JOB_URI = f"{JES_URI}/jobs"
+
+
+class SASJobExecutionOperator(BaseOperator):
+ """
+ Executes a SAS Job
+
+ .. seealso::
+ For more information on how to use this operator, take a look at the guide:
+ :ref:`howto/operator:SASJobExecutionOperator`
+
+ :param connection_name: Name of the SAS Viya connection stored as an Airflow HTTP connection
+ :param job_name: Name of the SAS Job to be run
+ :param parameters Dictionary of all the parameters that should be passed to the
+ SAS Job as SAS Macro variables
+ """
+
+ def __init__(self, connection_name: str, job_name: str, parameters: dict, **kwargs) -> None:
+ super().__init__(**kwargs)
+ self.connection_name = connection_name
+ self.job_name = job_name
+ self.parameters = parameters
+
+ def execute(self, context):
+ session = create_session_for_connection(self.connection_name)
+
+ print(f"Executing SAS job: {self.job_name}")
Review Comment:
Use `self.log.{log_level}` instead of `print`. All subclasses of `BaseOperator` and `BaseHook` already have attribute `log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AndrewShakinovsky-SAS closed pull request #28503: Initial support for SAS community provider
Posted by GitBox <gi...@apache.org>.
AndrewShakinovsky-SAS closed pull request #28503: Initial support for SAS community provider
URL: https://github.com/apache/airflow/pull/28503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28503: Initial support for SAS community provider
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28503:
URL: https://github.com/apache/airflow/pull/28503#issuecomment-1360039716
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org