You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/07 07:13:02 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new issue #4286: Why does DECIMALV2 cast to PackedInt128 in RawValue::print_value()?
vagetablechicken opened a new issue #4286:
URL: https://github.com/apache/incubator-doris/issues/4286
https://github.com/apache/incubator-doris/blob/eefad13107ac74a406212e0f0f57181973ac9c1e/be/src/runtime/raw_value.cpp#L168-L170
Why not to use DecimalV2Value, to enhance readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on issue #4286: Why does DECIMALV2 cast to PackedInt128 in RawValue::print_value()?
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on issue #4286:
URL: https://github.com/apache/incubator-doris/issues/4286#issuecomment-670421371
> cause decimal_v2 use int128_t, C++ compiler will do some optimized for it. But the DecimalV2 value is not ensured to be aligned, which will cause crash.
But it's printing a `const void* value`.
And I've seen some reinterpret_cast to DecimalV2Value, e.g.
https://github.com/apache/incubator-doris/blob/eefad13107ac74a406212e0f0f57181973ac9c1e/be/src/exec/tablet_sink.cpp#L851-L853
So it's wrong to do like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #4286: Why does DECIMALV2 cast to PackedInt128 in RawValue::print_value()?
Posted by GitBox <gi...@apache.org>.
imay commented on issue #4286:
URL: https://github.com/apache/incubator-doris/issues/4286#issuecomment-670378957
cause decimal_v2 use int128_t, C++ compiler will do some optimized for it. But the DecimalV2 value is not ensured to be aligned, which will cause crash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org