You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "togami2864 (via GitHub)" <gi...@apache.org> on 2023/02/17 05:27:48 UTC
[GitHub] [arrow-rs] togami2864 opened a new pull request, #3731: Enable to write NaN and Infinity of float as json string
togami2864 opened a new pull request, #3731:
URL: https://github.com/apache/arrow-rs/pull/3731
# Which issue does this PR close?
# Rationale for this change
Now if the `RecordBatch` has float64array including f64 constants like `NaN`, `Infinity`, `-Infinity`, the json output is `{}`.
This PR enables `writer.write_batches()` to output them as string.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3731: Enable to write NaN and Infinity of float as json string
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3731:
URL: https://github.com/apache/arrow-rs/pull/3731#issuecomment-1434359770
Will these strings roundtrip through the reader? FWIW I thought the JSON spec defined these values to be written as null, which is what serde_json does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] togami2864 commented on pull request #3731: Enable to write NaN and Infinity of float as json string
Posted by "togami2864 (via GitHub)" <gi...@apache.org>.
togami2864 commented on PR #3731:
URL: https://github.com/apache/arrow-rs/pull/3731#issuecomment-1435478903
Sorry, I misunderstood json spec. It serializes `NaN` & `Infinity` to "null" and `serde_json` also does.
Actually, I wanted to reproduce BigQuery behavior, but I should do it with a workaround...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] togami2864 closed pull request #3731: Enable to write NaN and Infinity of float as json string
Posted by "togami2864 (via GitHub)" <gi...@apache.org>.
togami2864 closed pull request #3731: Enable to write NaN and Infinity of float as json string
URL: https://github.com/apache/arrow-rs/pull/3731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org