You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/05 04:49:30 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file

dongjoon-hyun edited a comment on issue #25357: [SPARK-28617][SQL][TEST] Completely remove comments from the golden result file
URL: https://github.com/apache/spark/pull/25357#issuecomment-518084351
 
 
   Although there is [a side effect](https://github.com/apache/spark/pull/25357#discussion_r310437023), this PR seems to have a bigger positive side than a negative side. I'm supporting this approach, @wangyum .
   
   cc @gatorsmile , @maropu , @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org