You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/25 21:12:43 UTC

[GitHub] [kafka] cgetzen opened a new pull request #8930: Mirror Maker 2: offset-syncs variable

cgetzen opened a new pull request #8930:
URL: https://github.com/apache/kafka/pull/8930


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #8930:
URL: https://github.com/apache/kafka/pull/8930#issuecomment-1035136857


   I believe this has been addressed by [KIP-690](https://cwiki.apache.org/confluence/display/KAFKA/KIP-690%3A+Add+additional+configuration+to+control+MirrorMaker+2+internal+topics+naming+convention), so closing this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cgetzen commented on pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
cgetzen commented on pull request #8930:
URL: https://github.com/apache/kafka/pull/8930#issuecomment-650381294


   Hi @ryannedolan, wondering if you could spare a little guidance.
   
   I created `offset-syncs.topic.override` variable with a default of `null`. What I would have loved to do is to create something like `offset-syncs.topic` with a default value of `mm2-offsets-sync.<ALIAS>.internal`, but was unable to due to the alias in the string, and think it would require a much larger change to do so. Thoughts?
   
   I also emailed dev@kafka.apache.org to get access to create a KIP, but that seems to be a dead end. If I get together the content for a KIP, would you be willing to submit it?
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison closed pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
mimaison closed pull request #8930:
URL: https://github.com/apache/kafka/pull/8930


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ryannedolan commented on pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
ryannedolan commented on pull request #8930:
URL: https://github.com/apache/kafka/pull/8930#issuecomment-650389551


   @cgetzen the larger change would be worth it IMO. I think a KIP is the right way forward. Happy to help, but you should be able to get permission to create a KIP yourself. Might just take a few tries, unfortunately. Maybe check who has been responding to such requests lately and reach out to them directly.
   
   Are there other properties that we could make more customizable in this way too? Might be a good time to address them all together.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cgetzen edited a comment on pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
cgetzen edited a comment on pull request #8930:
URL: https://github.com/apache/kafka/pull/8930#issuecomment-650381294


   Hi @ryannedolan, wondering if you could spare a little guidance.
   
   I created `offset-syncs.topic.override` variable with a default of `null`. What I would have loved to do is to create something like `offset-syncs.topic` with a default value of `mm2-offsets-sync.<ALIAS>.internal`, but was unable due to the alias in the string, and think it would require a much larger change to do so. Thoughts?
   
   I also emailed dev@kafka.apache.org to get access to create a KIP, but that seems to be a dead end. If I get together the content for a KIP, would you be willing to submit it?
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cgetzen commented on pull request #8930: Mirror Maker 2: offset-syncs variable

Posted by GitBox <gi...@apache.org>.
cgetzen commented on pull request #8930:
URL: https://github.com/apache/kafka/pull/8930#issuecomment-651268347


   Much appreciated. Another property is the heartbeats topic.
   I will create the KIP as soon as I get my head around all the different types of configs and how they work together. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org