You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by buggtb <gi...@git.apache.org> on 2015/07/23 19:16:29 UTC
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
GitHub user buggtb opened a pull request:
https://github.com/apache/oodt/pull/23
OODT-859 add bundle headers to files to allow for OSGI usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/OSBI/oodt upstream2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/oodt/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit a7be6105471ca9d44c8714df1232220bb15957eb
Author: Tom Barber <to...@analytical-labs.com>
Date: 2015-07-23T15:08:49Z
filemgr convert to bundle
commit 94c0b3815052b0f230096cdbc68f11601f271c9a
Author: Tom Barber <to...@analytical-labs.com>
Date: 2015-07-23T15:15:53Z
OODT-859 convert filemgr to bundle, extra profile to add dependencies into jar to stop karaf crying
commit 2e3d21ccd698689a8cc1e37649061e5c812d3e5f
Author: Tom Barber <to...@analytical-labs.com>
Date: 2015-07-23T17:07:47Z
OODT-859 convert to bundles
commit b4966909ab1b908b4b6508d5d2b8e96b63fa5cfe
Author: Tom Barber <to...@analytical-labs.com>
Date: 2015-07-23T17:13:34Z
changes
commit d075cefb7624d4b247c337bb0b11d5fc69e1cfd0
Author: Tom Barber <to...@analytical-labs.com>
Date: 2015-07-23T17:15:41Z
remove iml files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/23#issuecomment-132331575
OKay I've created a branch I'll push this PR to it later. I would like to try and come up with a way of not requiring the uber bundle, but that will take a bit of fiddling, so i'll do it on a separate branch over the next week or so
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on the pull request:
https://github.com/apache/oodt/pull/23#issuecomment-124190700
I'll try and swap them back the output is the same you still get a jar but
it wasn't packaging properly with jar defined but that's just plugin
annoyances. But yes I'll move those out somewhere.
Tom
On 23 Jul 2015 19:08, "Chris Mattmann" <no...@github.com> wrote:
> gotcha. That's fine, well then I wouldn't change the default packaging of
> the components from jar to bundle then. As you are doing in a profile
> anyways with the plugin and dependencies, make the packaging also something
> that is dependent on the profile. I am +1 as long as it doesn't change the
> default behavior of jar packaging on these. @buggtb
> <https://github.com/buggtb>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/oodt/pull/23#issuecomment-124189993>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] oodt pull request: OODT-859 add bundle headers to files
to allow f...
Posted by Tom Barber <to...@meteorite.bi>.
Ooohh now you love it?! Yeah, I've got a couple of hours and I implemented
the changes you asked for somewhere, let me dig them out, I'll post it
later tonight.
On Tue, Aug 18, 2015 at 6:07 PM, chrismattmann <gi...@git.apache.org> wrote:
> Github user chrismattmann commented on the pull request:
>
> https://github.com/apache/oodt/pull/23#issuecomment-132281753
>
> @buggtb this is a very useful addition - do you have an update here?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by chrismattmann <gi...@git.apache.org>.
Github user chrismattmann commented on the pull request:
https://github.com/apache/oodt/pull/23#issuecomment-132281753
@buggtb this is a very useful addition - do you have an update here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by chrismattmann <gi...@git.apache.org>.
Github user chrismattmann commented on the pull request:
https://github.com/apache/oodt/pull/23#issuecomment-124189993
gotcha. That's fine, well then I wouldn't change the default packaging of the components from jar to bundle then. As you are doing in a profile anyways with the plugin and dependencies, make the packaging also something that is dependent on the profile. I am +1 as long as it doesn't change the default behavior of jar packaging on these. @buggtb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb commented on a diff in the pull request:
https://github.com/apache/oodt/pull/23#discussion_r35351331
--- Diff: crawler/pom.xml ---
@@ -27,6 +27,7 @@ the License.
<artifactId>cas-crawler</artifactId>
<name>Catalog and Archive Crawling Framework</name>
<description>The Catalog and Archive Service Crawling Framework.</description>
+ <packaging>bundle</packaging>
--- End diff --
Makes me sad I spent hours copying and pasting!
But your plan also doesn't fit my idea because bundling all of oodt into a
mega bundle is a bloat that isn't required. For example I just want to
deploy a file manager and expose it via DOSGI to a main server, why would I
deploy a massive jar for a very light weight requirement.
I started by creating a wrapper jar for it but I figured as we're only
changing a very default manifest file actually pushing it down to the Base
jars made more sense.
On 23 Jul 2015 18:48, "Chris Mattmann" <no...@github.com> wrote:
> In crawler/pom.xml
> <https://github.com/apache/oodt/pull/23#discussion_r35350102>:
>
> > @@ -27,6 +27,7 @@ the License.
> > <artifactId>cas-crawler</artifactId>
> > <name>Catalog and Archive Crawling Framework</name>
> > <description>The Catalog and Archive Service Crawling Framework.</description>
> > + <packaging>bundle</packaging>
>
> maybe we shouldn't change the default packaging per project, but instead
> create an oodt-bundle that is packaged as an OSGI bundle that combines the
> constituent sub projects.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/oodt/pull/23/files#r35350102>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by buggtb <gi...@git.apache.org>.
Github user buggtb closed the pull request at:
https://github.com/apache/oodt/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] oodt pull request: OODT-859 add bundle headers to files to allow f...
Posted by chrismattmann <gi...@git.apache.org>.
Github user chrismattmann commented on a diff in the pull request:
https://github.com/apache/oodt/pull/23#discussion_r35350102
--- Diff: crawler/pom.xml ---
@@ -27,6 +27,7 @@ the License.
<artifactId>cas-crawler</artifactId>
<name>Catalog and Archive Crawling Framework</name>
<description>The Catalog and Archive Service Crawling Framework.</description>
+ <packaging>bundle</packaging>
--- End diff --
maybe we shouldn't change the default packaging per project, but instead create an oodt-bundle that is packaged as an OSGI bundle that combines the constituent sub projects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---