You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/14 07:39:51 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1083: Ftr: uniform router support
LaurenceLiZhixin opened a new pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
This pr add uniform router feature, and delete old routers' impl.
User can use local config file, or load config and refresh router by using k8s CRD.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (7d01274) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `1.71%`.
> The diff coverage is `62.31%`.
> :exclamation: Current head 7d01274 differs from pull request most recent head 27ff1f7. Consider uploading reports for the commit 27ff1f7 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 58.32% -1.72%
==========================================
Files 260 248 -12
Lines 12855 12385 -470
==========================================
- Hits 7718 7224 -494
- Misses 4174 4243 +69
+ Partials 963 918 -45
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `60.60% <ø> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (ø)` | |
| [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `90.24% <ø> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| ... and [192 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [ca7f3a8...27ff1f7](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (27ff1f7) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `1.74%`.
> The diff coverage is `62.48%`.
> :exclamation: Current head 27ff1f7 differs from pull request most recent head 685c97c. Consider uploading reports for the commit 685c97c to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 58.29% -1.75%
==========================================
Files 260 251 -9
Lines 12855 12381 -474
==========================================
- Hits 7718 7217 -501
- Misses 4174 4250 +76
+ Partials 963 914 -49
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `60.60% <ø> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (ø)` | |
| [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `90.24% <ø> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| ... and [197 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [f39cc52...685c97c](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#discussion_r606666609
##########
File path: cluster/router/uniform/factory_test.go
##########
@@ -15,26 +15,18 @@
* limitations under the License.
*/
-package tag
-
-import (
- "testing"
-)
+package uniform
import (
"github.com/stretchr/testify/assert"
+ "testing"
Review comment:
move package to first import()
##########
File path: cluster/router/uniform/factory_test.go
##########
@@ -15,26 +15,18 @@
* limitations under the License.
*/
-package tag
-
-import (
- "testing"
-)
+package uniform
import (
"github.com/stretchr/testify/assert"
+ "testing"
Review comment:
move package to first import()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (7d01274) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `1.71%`.
> The diff coverage is `62.31%`.
> :exclamation: Current head 7d01274 differs from pull request most recent head a668c79. Consider uploading reports for the commit a668c79 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 58.32% -1.72%
==========================================
Files 260 248 -12
Lines 12855 12385 -470
==========================================
- Hits 7718 7224 -494
- Misses 4174 4243 +69
+ Partials 963 918 -45
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `60.60% <ø> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (ø)` | |
| [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `90.24% <ø> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| ... and [192 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [ca7f3a8...a668c79](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (7d01274) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `1.71%`.
> The diff coverage is `62.31%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 58.32% -1.72%
==========================================
Files 260 248 -12
Lines 12855 12385 -470
==========================================
- Hits 7718 7224 -494
- Misses 4174 4243 +69
+ Partials 963 918 -45
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `60.60% <ø> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (ø)` | |
| [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `90.24% <ø> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| ... and [192 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [78bea16...7d01274](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-801631231
If this pr has not been completed, pls add [WIP] before ur pr title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (945f67c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `2.54%`.
> The diff coverage is `53.15%`.
> :exclamation: Current head 945f67c differs from pull request most recent head 32981f0. Consider uploading reports for the commit 32981f0 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 57.49% -2.55%
==========================================
Files 260 262 +2
Lines 12855 12693 -162
==========================================
- Hits 7718 7298 -420
- Misses 4174 4464 +290
+ Partials 963 931 -32
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `76.47% <ø> (ø)` | |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `66.66% <ø> (ø)` | |
| [cluster/cluster\_impl/failsafe\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbHNhZmVfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `60.60% <ø> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (ø)` | |
| [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `90.24% <ø> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| ... and [217 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [78bea16...32981f0](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #1083: [WIP] Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#issuecomment-802546222
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=h1) Report
> Merging [#1083](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=desc) (cbbe332) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `2.67%`.
> The diff coverage is `44.31%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.0 #1083 +/- ##
==========================================
- Coverage 60.03% 57.36% -2.68%
==========================================
Files 260 261 +1
Lines 12855 12885 +30
==========================================
- Hits 7718 7391 -327
- Misses 4174 4559 +385
+ Partials 963 935 -28
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXIuZ28=) | `100.00% <ø> (ø)` | |
| [cluster/cluster\_impl/zone\_aware\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvem9uZV9hd2FyZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `64.28% <ø> (ø)` | |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `62.96% <ø> (-0.87%)` | :arrow_down: |
| [cluster/router/uniform/dubbo\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9kdWJib19ydWxlLmdv) | `0.00% <0.00%> (ø)` | |
| [...er/uniform/match\_judger/attachment\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvYXR0YWNobWVudF9tYXRjaF9qdWRnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...r/router/uniform/match\_judger/bool\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvYm9vbF9tYXRjaF9qdWRnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...router/uniform/match\_judger/double\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvZG91YmxlX21hdGNoX2p1ZGdlci5nbw==) | `0.00% <0.00%> (ø)` | |
| [.../uniform/match\_judger/double\_range\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvZG91YmxlX3JhbmdlX21hdGNoX2p1ZGdlci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...r/uniform/match\_judger/list\_double\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvbGlzdF9kb3VibGVfbWF0Y2hfanVkZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
| [...r/uniform/match\_judger/list\_string\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdW5pZm9ybS9tYXRjaF9qdWRnZXIvbGlzdF9zdHJpbmdfbWF0Y2hfanVkZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
| ... and [143 more](https://codecov.io/gh/apache/dubbo-go/pull/1083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=footer). Last update [9926081...cbbe332](https://codecov.io/gh/apache/dubbo-go/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #1083: Ftr: uniform router support
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #1083:
URL: https://github.com/apache/dubbo-go/pull/1083#discussion_r606666357
##########
File path: cluster/router/chain/chain.go
##########
@@ -234,10 +152,14 @@ func NewRouterChain(url *common.URL) (*RouterChain, error) {
}
routers := make([]router.PriorityRouter, 0, len(routerFactories))
+
for key, routerFactory := range routerFactories {
- r, err := routerFactory().NewPriorityRouter(url, chain.notify)
+ if virtualServiceConfigByte == nil || destinationRuleConfigByte == nil {
+ logger.Errorf("virtual Service Config or destinationRule Confi Byte may be empty, pls check your CONF_VIRTUAL_SERVICE_FILE_PATH and CONF_DEST_RULE_FILE_PATH env is correctly point to your yaml file\n")
Review comment:
change the log level to warn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org