You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/02/01 00:16:32 UTC
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9173
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 60 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9173/1
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1911/
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 07:17:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9173
to look at the new patch set (#4).
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
The affected flags are:
be_service_threads, cgroup_hierarchy_path, enable_accept_queue_server,
enable_partitioned_aggregation, enable_partitioned_hash_join,
enable_phj_probe_side_filtering, enable_rm, llama_addresses,
llama_callback_port, llama_host, llama_max_request_attempts,
llama_port, llama_registration_timeout_secs,
llama_registration_wait_secs, local_nodemanager_url,
resource_broker_cnxn_attempts, resource_broker_cnxn_retry_interval_ms,
resource_broker_recv_timeout, resource_broker_send_timeout,
rm_always_use_defaults, rm_default_cpu_vcores, rm_default_memory,
rpc_cnxn_attempts, rpc_cnxn_retry_interval_ms, staging_cgroup,
suppress_unknown_disk_id_warnings, use_statestore,
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Cherry-picks: not for 2.x
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 54 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9173/4
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 2:
(2 comments)
I convinced myself with the following command that the flags aren't used anywhere anymore:
tail -n 27 be/src/common/global-flags.cc | cut -d '(' -f 2 | cut -d ')' -f 1 | while read f; do git grep FLAGS_$f; done
http://gerrit.cloudera.org:8080/#/c/9173/2//COMMIT_MSG
Commit Message:
PS2:
Should give the flags an honorary mention in the commit message so that they become searchable in git log?
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc@209
PS2, Line 209: jgs
I like this! However, I suspect jgs refers to stuff from this website: http://www.oocities.org/spunk1111/
Does the copyright allow us to include it here?
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:28:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Cherry-picks: not for 2.x
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 60 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9173/2
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 20:01:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9173/2//COMMIT_MSG
Commit Message:
PS2:
> Should give the flags an honorary mention in the commit message so that the
Done
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
http://gerrit.cloudera.org:8080/#/c/9173/2/be/src/common/global-flags.cc@209
PS2, Line 209: jgs
> I like this! However, I suspect jgs refers to stuff from this website: http
You're right, the license is not clear. I replaced with my own inferior art.
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:58:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 3: Code-Review+2
LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 16:56:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1914/
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 16:22:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1911/
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 04:19:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
The affected flags are:
be_service_threads, cgroup_hierarchy_path, enable_accept_queue_server,
enable_partitioned_aggregation, enable_partitioned_hash_join,
enable_phj_probe_side_filtering, enable_rm, llama_addresses,
llama_callback_port, llama_host, llama_max_request_attempts,
llama_port, llama_registration_timeout_secs,
llama_registration_wait_secs, local_nodemanager_url,
resource_broker_cnxn_attempts, resource_broker_cnxn_retry_interval_ms,
resource_broker_recv_timeout, resource_broker_send_timeout,
rm_always_use_defaults, rm_default_cpu_vcores, rm_default_memory,
rpc_cnxn_attempts, rpc_cnxn_retry_interval_ms, staging_cgroup,
suppress_unknown_disk_id_warnings, use_statestore,
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Cherry-picks: not for 2.x
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Reviewed-on: http://gerrit.cloudera.org:8080/9173
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 54 insertions(+), 47 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
The affected flags are:
be_service_threads, cgroup_hierarchy_path, enable_accept_queue_server,
enable_partitioned_aggregation, enable_partitioned_hash_join,
enable_phj_probe_side_filtering, enable_rm, llama_addresses,
llama_callback_port, llama_host, llama_max_request_attempts,
llama_port, llama_registration_timeout_secs,
llama_registration_wait_secs, local_nodemanager_url,
resource_broker_cnxn_attempts, resource_broker_cnxn_retry_interval_ms,
resource_broker_recv_timeout, resource_broker_send_timeout,
rm_always_use_defaults, rm_default_cpu_vcores, rm_default_memory,
rpc_cnxn_attempts, rpc_cnxn_retry_interval_ms, staging_cgroup,
suppress_unknown_disk_id_warnings, use_statestore,
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Cherry-picks: not for 2.x
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 54 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9173/5
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9173
to look at the new patch set (#3).
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
IMPALA-3271: organise and warn on removed startup flags
Gather all the removed flags in a single place and establish consistent
behaviour.
If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.
The affected flags are:
be_service_threads, cgroup_hierarchy_path, enable_accept_queue_server,
enable_partitioned_aggregation, enable_partitioned_hash_join,
enable_phj_probe_side_filtering, enable_rm, llama_addresses,
llama_callback_port, llama_host, llama_max_request_attempts,
llama_port, llama_registration_timeout_secs,
llama_registration_wait_secs, local_nodemanager_url,
resource_broker_cnxn_attempts, resource_broker_cnxn_retry_interval_ms,
resource_broker_recv_timeout, resource_broker_send_timeout,
rm_always_use_defaults, rm_default_cpu_vcores, rm_default_memory,
rpc_cnxn_attempts, rpc_cnxn_retry_interval_ms, staging_cgroup,
suppress_unknown_disk_id_warnings, use_statestore,
Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log
Cherry-picks: not for 2.x
Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 55 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/9173/3
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1898/
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:05:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5:
Looks like some kind of jenkins glitch
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 16:22:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 4: Code-Review+2
Rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 17:07:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 5: Code-Review+2
Fix compile error from backslash in comment
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 04:19:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 02:25:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 )
Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1898/
--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 17:07:57 +0000
Gerrit-HasComments: No