You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/17 08:41:15 UTC

[GitHub] [dolphinscheduler] wen-hemin commented on a change in pull request #5832: [Improvement][Api Module] refactor DataSourceParam and DependentParam, remove spring annotation

wen-hemin commented on a change in pull request #5832:
URL: https://github.com/apache/dolphinscheduler/pull/5832#discussion_r671644600



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -720,23 +723,50 @@ public ProcessMeta exportProcessMetaData(ProcessDefinition processDefinition) {
     }
 
     /**
-     * correct task param which has datasource or dependent
+     * correct task param which has datasource or dependent for export

Review comment:
       Thx, I'll fix comment.
   This is used for import and export process. In the future, if there are inject other parameters, you can refactor again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org