You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jvdvegt (via GitHub)" <gi...@apache.org> on 2026/03/25 15:09:45 UTC
[PR] ISSUE_469: Add '_MM' versions for all SHA-algorithms, which prevents… [maven-build-cache-extension]
jvdvegt opened a new pull request, #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470
…copying files in memory.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
**NB: this fails on 'null/org/apache/maven/extensions/maven-build-cache-extension/${projectVersion}/maven-build-cache-extension-${projectVersion}.pom.lastUpdated', which seems unrelated).**
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ISSUE_469: Add '_MM' versions for all SHA-algorithms, which prevents… [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4152352341
Looks like a very good improvement! Thanks!
I wonder if you could mention this in this documentation page https://maven.apache.org/extensions/maven-build-cache-extension/performance.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4233414553
@jvdvegt the sources for the page are in the repo https://github.com/apache/maven-build-cache-extension/blob/master/src/site/markdown/performance.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "jvdvegt (via GitHub)" <gi...@apache.org>.
jvdvegt commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4267233531
@olamy : I think I rebased it (I'm not very familiar with GitHub multi-repos). Thanks for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4263969612
@jvdvegt thanks for your hard. I fixed test in `master`. can you just rebase, we get a last green build and this will be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "jvdvegt (via GitHub)" <gi...@apache.org>.
jvdvegt commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4182467258
> Looks like a very good improvement! Thanks! I wonder if you could mention this in this documentation page https://maven.apache.org/extensions/maven-build-cache-extension/performance.html
Yes, will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470#issuecomment-4267773876
@jvdvegt all merged. Thanks for your contribution! (and patience :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not read a JAR completely into a byte-array before computing the SHA [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #470:
URL: https://github.com/apache/maven-build-cache-extension/pull/470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org