You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/24 14:35:39 UTC
[GitHub] [spark] AngersZhuuuu commented on issue #24973: [SPARK-28169][SQL]
Fix Partition table partition PushDown failed by "OR" expression
AngersZhuuuu commented on issue #24973: [SPARK-28169][SQL] Fix Partition table partition PushDown failed by "OR" expression
URL: https://github.com/apache/spark/pull/24973#issuecomment-514658814
> This place is definitely not the only place that extracts partition predicates (e.g. `FileSourceStrategy`), I'm -1 to add a hack just in this place. I still prefer to add a CNF conversion rule to solve this problem for all the places, or other general solutions.
Checked previous activity for the CNF normalization in below issue:
https://issues.apache.org/jira/browse/SPARK-6624
Seems we can't make it as an Optimizer Rule, it should only work for some special point such as partition predicate and filter push down。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org