You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/10/05 12:28:18 UTC

[GitHub] [libcloud] tgn-outscale opened a new pull request #1499: Adding external features to Outscale Provider

tgn-outscale opened a new pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499


   ## Adding external features to Outscale Provider
   
   ### Description
   
   This PR is adding all of the currently available Outscale API features to the Outscale Provider in libcloud and it's corresponding documentation:
   
   - Public Ips
   - Accounts
   - Tags
   - Region and Subregions
   - Access Keys
   - Client Gateways
   - Dhcp Options
   - Direct Links
   - Direct Link Interfaces
   - Flexible GPUs
   - Internet Services
   - Listener
   - Load Balancer
   - Load Balancer Policies
   - Nat Services
   - Nets
   - Net Access Points
   - Net Peerings
   - Nics
   - Product Types
   - Quotas
   - Routes
   - Routes Tables
   - Server Certificates
   - Virtual Gateways
   - Security Groups
   - Security Group Rules
   - Subnets
   - Tasks
   - VPN Connectons
   - Nodes
   
   ### Status
   
   - done, ready for review
   
   ### Checklist
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
   - [x] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-io edited a comment on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-735944556


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=h1) Report
   > Merging [#1499](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=desc) (6c987a9) into [trunk](https://codecov.io/gh/apache/libcloud/commit/66ab3cad69a79dd60e7115761546ecdbfa7da7a1?el=desc) (66ab3ca) will **decrease** coverage by `1.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1499/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69)](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1499      +/-   ##
   ==========================================
   - Coverage   84.77%   82.98%   -1.79%     
   ==========================================
     Files         388      388              
     Lines       81718    83639    +1921     
     Branches     8270     8881     +611     
   ==========================================
   + Hits        69278    69412     +134     
   - Misses       9440    11227    +1787     
     Partials     3000     3000              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/drivers/outscale.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL291dHNjYWxlLnB5) | `8.67% <ø> (-10.68%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=footer). Last update [66ab3ca...6c987a9](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-739525386


   Thanks for addressing the feedback. The changes have now been merged into trunk.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] codecov-io commented on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-735944556


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=h1) Report
   > Merging [#1499](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=desc) (ad3e73b) into [trunk](https://codecov.io/gh/apache/libcloud/commit/9e5c9cfd6dde1b8c92686bf900f546b0790449ae?el=desc) (9e5c9cf) will **decrease** coverage by `1.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1499/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69)](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1499      +/-   ##
   ==========================================
   - Coverage   84.77%   82.98%   -1.79%     
   ==========================================
     Files         388      388              
     Lines       81512    83639    +2127     
     Branches     8242     8881     +639     
   ==========================================
   + Hits        69102    69410     +308     
   - Misses       9422    11228    +1806     
   - Partials     2988     3001      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [libcloud/compute/drivers/outscale.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL291dHNjYWxlLnB5) | `8.67% <ø> (-10.68%)` | :arrow_down: |
   | [libcloud/test/dns/test\_digitalocean.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9kaWdpdGFsb2NlYW4ucHk=) | `90.72% <0.00%> (-9.28%)` | :arrow_down: |
   | [libcloud/test/dns/test\_base.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9iYXNlLnB5) | `97.01% <0.00%> (-2.99%)` | :arrow_down: |
   | [libcloud/test/storage/test\_local.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfbG9jYWwucHk=) | `91.41% <0.00%> (-2.24%)` | :arrow_down: |
   | [libcloud/dns/drivers/cloudflare.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvY2xvdWRmbGFyZS5weQ==) | `93.02% <0.00%> (-0.67%)` | :arrow_down: |
   | [libcloud/compute/drivers/digitalocean.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2RpZ2l0YWxvY2Vhbi5weQ==) | `84.86% <0.00%> (-0.33%)` | :arrow_down: |
   | [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <0.00%> (-0.01%)` | :arrow_down: |
   | [libcloud/test/compute/test\_vultr.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfdnVsdHIucHk=) | `100.00% <0.00%> (ø)` | |
   | [libcloud/dns/drivers/digitalocean.py](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvZGlnaXRhbG9jZWFuLnB5) | `92.59% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1499/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=footer). Last update [9e5c9cf...ad3e73b](https://codecov.io/gh/apache/libcloud/pull/1499?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] tgn-outscale edited a comment on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
tgn-outscale edited a comment on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-739792424


   Thanks for the review @Kami,
   I will probably look into adding some exceptions later but I will be quite busy for now with some other task,
   I will make a new PR in time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] Kami commented on a change in pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#discussion_r537062848



##########
File path: libcloud/compute/drivers/outscale.py
##########
@@ -73,6 +76,23 @@ def __init__(self,
         }
 
     def list_locations(self, ex_dry_run: bool = False):
+        """
+        Lists available locations details.
+
+        :param      ex_dry_run: If true, checks whether you have the required
+        permissions to perform the action.
+        :type       ex_dry_run: ``bool``
+        :return: locations details
+        :rtype: ``dict``
+        """
+        action = "ReadLocations"
+        data = json.dumps({"DryRun": ex_dry_run})
+        response = self._call_api(action, data)
+        if response.status_code == 200:

Review comment:
       Eventually we should move some of this error handling code to the Response class - this way we can avoid all this duplicated lines, but that's fine for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] tgn-outscale commented on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
tgn-outscale commented on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-739792424


   Thanks for the review @Kami,
   I will probably look into adding some exceptions later but I will be quite busy for now with some other task,
   I will let you now in time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] tgn-outscale commented on pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
tgn-outscale commented on pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499#issuecomment-723928249


   Hi @Kami,
   Thanks for the review, and sorry for the delay
   I will look into it and come back to you as soon as possible


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] asfgit merged pull request #1499: Adding external features to Outscale Provider

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1499:
URL: https://github.com/apache/libcloud/pull/1499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org