You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2023/05/10 17:06:07 UTC

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19868


Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................

IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

For CTAS statements that create Kudu/Iceberg tables the lineage log
was incomplete as it missed the table creation time of the newly
created table. This information was missing because in CatalogOpExecutor
createKuduTable() / createIcebergTable() did not set it in the
TDdlExecResponse object. This patch adds the missing information.

Testing
 * e2e test

Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
---
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_lineage.py
3 files changed, 49 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/19868/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19868

to look at the new patch set (#3).

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................

IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

For CTAS statements that create Kudu/Iceberg tables the lineage log
was incomplete as it missed the table creation time of the newly
created table. This information was missing because in CatalogOpExecutor
createKuduTable() / createIcebergTable() did not set it in the
TDdlExecResponse object. This patch adds the missing information.

Testing
 * e2e test

Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
---
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_lineage.py
3 files changed, 62 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/19868/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9311/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 13:33:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 18:58:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................

IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

For CTAS statements that create Kudu/Iceberg tables the lineage log
was incomplete as it missed the table creation time of the newly
created table. This information was missing because in CatalogOpExecutor
createKuduTable() / createIcebergTable() did not set it in the
TDdlExecResponse object. This patch adds the missing information.

Testing
 * e2e test

Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Reviewed-on: http://gerrit.cloudera.org:8080/19868
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Gabor Kaszab <ga...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_lineage.py
3 files changed, 62 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Gabor Kaszab: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13001/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 16:13:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12988/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 17:27:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 11:35:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12993/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 08:47:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19868 )

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 07:20:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19868

to look at the new patch set (#2).

Change subject: IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables
......................................................................

IMPALA-12130: Table creation time is not set properly in lineage log for Kudu and Iceberg tables

For CTAS statements that create Kudu/Iceberg tables the lineage log
was incomplete as it missed the table creation time of the newly
created table. This information was missing because in CatalogOpExecutor
createKuduTable() / createIcebergTable() did not set it in the
TDdlExecResponse object. This patch adds the missing information.

Testing
 * e2e test

Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
---
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_lineage.py
3 files changed, 53 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/19868/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6938938b1834809d5197a748c171e9a09e13906a
Gerrit-Change-Number: 19868
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>