You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by aarondav <gi...@git.apache.org> on 2014/03/23 06:40:08 UTC

[GitHub] spark pull request: SPARK-1099: Introduce local[*] mode to infer n...

Github user aarondav commented on the pull request:

    https://github.com/apache/spark/pull/182#issuecomment-38374752
  
    @mridulm Taking in your comments, I realized that my main concern was that people new to spark who run spark-shell or pyspark for the first time are probably expecting their code to run in parallel on multiple cores.
    
    Therefore, instead of breaking "local" mode, I modified the PR to add a "local[*]" mode which has the behavior of using all your machine's logical cores. This becomes the new default for spark-shell and pyspark, but otherwise all other code paths are unaffected.
    
    Does this seem reasonable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---