You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/23 13:49:11 UTC
[GitHub] [apisix-ingress-controller] shreemaan-abhishek opened a new pull request, #1553: feat: sync apisix upstream labels
shreemaan-abhishek opened a new pull request, #1553:
URL: https://github.com/apache/apisix-ingress-controller/pull/1553
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
- [x] New feature provided
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fixes #775
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1553: feat: sync apisix upstream labels
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1553:
URL: https://github.com/apache/apisix-ingress-controller/pull/1553#issuecomment-1367827584
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1553](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a614f5e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/486b46abd1c9665005e83036433af213aaa28f21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486b46a) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 41.44% 41.43% -0.02%
==========================================
Files 87 87
Lines 7420 7422 +2
==========================================
Hits 3075 3075
- Misses 3990 3991 +1
- Partials 355 356 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...kg/providers/apisix/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `60.75% <0.00%> (-1.58%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1553: feat: sync apisix upstream labels
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1553:
URL: https://github.com/apache/apisix-ingress-controller/pull/1553#discussion_r1059281950
##########
pkg/providers/apisix/translation/apisix_upstream.go:
##########
@@ -141,6 +141,7 @@ func (t *translator) translateExternalApisixUpstream(namespace, upstream string)
if err != nil {
return nil, err
}
+ ups.Metadata.Labels = au.ObjectMeta.Labels
Review Comment:
I don't think this is appropriate, it will overwrite all labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1553: feat: sync apisix upstream labels
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1553:
URL: https://github.com/apache/apisix-ingress-controller/pull/1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org