You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@vitalstatistix.ics.uci.edu> on 2019/11/26 00:28:55 UTC
Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343 )
Change subject: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
......................................................................
[NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Do not push empty frames to next operator in primary index
upsert operator.
Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
---
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/4343/1
diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
index b855981..e05ddb7 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
@@ -113,6 +113,7 @@
private final ITracer tracer;
private final long traceCategory;
private long lastRecordInTimeStamp = 0L;
+ private boolean emptyFrame;
public LSMPrimaryUpsertOperatorNodePushable(IHyracksTaskContext ctx, int partition,
IIndexDataflowHelperFactory indexHelperFactory, int[] fieldPermutation, RecordDescriptor inputRecDesc,
@@ -266,7 +267,9 @@
@Override
public void frameCompleted() throws HyracksDataException {
- appender.write(writer, true);
+ if (!emptyFrame) {
+ appender.write(writer, true);
+ }
callback.frameCompleted();
}
@@ -319,9 +322,9 @@
@Override
public void nextFrame(ByteBuffer buffer) throws HyracksDataException {
accessor.reset(buffer);
- int itemCount = accessor.getTupleCount();
+ emptyFrame = accessor.getTupleCount() <= 0;
lsmAccessor.batchOperate(accessor, tuple, processor, frameOpCallback);
- if (itemCount > 0) {
+ if (!emptyFrame) {
lastRecordInTimeStamp = System.currentTimeMillis();
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
Gerrit-Change-Number: 4343
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
Posted by AsterixDB Code Review <do...@vitalstatistix.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343 )
Change subject: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/FK2A : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
Gerrit-Change-Number: 4343
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 26 Nov 2019 00:36:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
Posted by AsterixDB Code Review <do...@vitalstatistix.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343 )
Change subject: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
......................................................................
[NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Do not push empty frames to next operator in primary index
upsert operator.
Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
---
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/4343/1
diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
index b855981..e05ddb7 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
@@ -113,6 +113,7 @@
private final ITracer tracer;
private final long traceCategory;
private long lastRecordInTimeStamp = 0L;
+ private boolean emptyFrame;
public LSMPrimaryUpsertOperatorNodePushable(IHyracksTaskContext ctx, int partition,
IIndexDataflowHelperFactory indexHelperFactory, int[] fieldPermutation, RecordDescriptor inputRecDesc,
@@ -266,7 +267,9 @@
@Override
public void frameCompleted() throws HyracksDataException {
- appender.write(writer, true);
+ if (!emptyFrame) {
+ appender.write(writer, true);
+ }
callback.frameCompleted();
}
@@ -319,9 +322,9 @@
@Override
public void nextFrame(ByteBuffer buffer) throws HyracksDataException {
accessor.reset(buffer);
- int itemCount = accessor.getTupleCount();
+ emptyFrame = accessor.getTupleCount() <= 0;
lsmAccessor.batchOperate(accessor, tuple, processor, frameOpCallback);
- if (itemCount > 0) {
+ if (!emptyFrame) {
lastRecordInTimeStamp = System.currentTimeMillis();
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
Gerrit-Change-Number: 4343
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
Posted by AsterixDB Code Review <do...@vitalstatistix.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343 )
Change subject: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/9440/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
Gerrit-Change-Number: 4343
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Tue, 26 Nov 2019 01:55:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[stabilization-f69489]: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
Posted by AsterixDB Code Review <do...@vitalstatistix.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343 )
Change subject: [NO ISSUE][RT] Do Not Forward Empty Frames in Primary Upsert
......................................................................
Patch Set 1: Contrib+1
Analytics Compatibility Tests Successful
https://cbjenkins.page.link/Zgd1 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4343
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Change-Id: I9c8fd6f3c1856af1e2d30cd52d026eeb7da5ab1d
Gerrit-Change-Number: 4343
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 26 Nov 2019 02:51:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment