You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2012/12/16 15:03:35 UTC

[VOTE] Release of commons-email-1.3 based on RC6

Hi,

I would like to call a vote from commons-email-1.3 based on RC6.

This release candidate has the following changes compared to RC5

+) fixed Clirr errors by reverting the changes related to refactoring
   of constants from Email to EmailConstants.

The files:

The artifacts are deployed to Nexus:
https://repository.apache.org/content/repositories/orgapachecommons-031/org/apache/commons/commons-email/1.3/

The tag:
https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_RC6/

The site:
http://people.apache.org/builds/commons/email/1.3/RC6/

Additional Notes:

o the download page and api links to older releases only work on
  the published site and will be corrected after release.

Please take a look at the commons-email-1.3 artifacts and vote!

------------------------------------------------
[ ] +1 release it.
[ ] +0 go ahead; I don't care.
[ ] -0 there are a few minor glitches: ...
[ ] -1 no, do not release it because ...
------------------------------------------------

Vote will remain open for at least 72 hours.

Thanks in advance,

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE][CANCEL] Release of commons-email-1.3 based on RC6

Posted by Gary Gregory <ga...@gmail.com>.
I'm OK with waiting.

Gary

On Mon, Dec 17, 2012 at 7:27 AM, Thomas Neidhart
<th...@gmail.com>wrote:

> Hi again,
>
> vote is cancelled, pending the missing @since tags and outdated links in
> the release notes.
> Also the unit tests which seem to be quite error-prone due to local
> environment / configuration should be adapted to prevent such situations in
> the future.
>
> Unfortunately, I will not have time to do a complete release before next
> year, so we either postpone it, or somebody else steps in.
>
> Thomas
>
> On Sun, Dec 16, 2012 at 6:58 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
>
> > On 12/16/2012 06:43 PM, Phil Steitz wrote:
> > > Artifacts look good.
> > > Sigs are good, key is in KEYS.
> > >
> > > Following are blockers IMO:
> > >
> > > 1) I am getting the test failures below though, running under:
> > >
> > > Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> > > Java version: 1.6.0_37
> > > Java home:
> > > /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> > > Default locale: en_US, platform encoding: MacRoman
> > > OS name: "mac os x" version: "10.7.5" arch: "x86_64" Family: "mac"
> >
> > this has already been observed by other people before, and it is most
> > likely related to a buggy DNS server in your environment. The unit tests
> > try resolve an invalid url (http://example.invalid), which seems to
> > succeed in your case. You can test it yourself by typing the url in your
> > browser.
> >
> > I am already in favor of changing the unit test to prevent such issues
> > again in the future, but imho this is not blocking a release.
> >
> > > 2) There are missing @since tags for the methods added to the Email
> > > class.
> > >
> > > Not a blocker, but should be fixed:
> > >
> > > 3) Release notes refer to obsolete Sun URLs.  These (sadly,
> > > typically) redirect to pages of no real value in finding the
> > > artifacts that they used to point to.  I would drop the URLs and
> > > reference to Sun.
> >
> > I will fix the other things.
> >
> > Thanks,
> >
> > Thomas
> >
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

[VOTE][CANCEL] Release of commons-email-1.3 based on RC6

Posted by Thomas Neidhart <th...@gmail.com>.
Hi again,

vote is cancelled, pending the missing @since tags and outdated links in
the release notes.
Also the unit tests which seem to be quite error-prone due to local
environment / configuration should be adapted to prevent such situations in
the future.

Unfortunately, I will not have time to do a complete release before next
year, so we either postpone it, or somebody else steps in.

Thomas

On Sun, Dec 16, 2012 at 6:58 PM, Thomas Neidhart
<th...@gmail.com>wrote:

> On 12/16/2012 06:43 PM, Phil Steitz wrote:
> > Artifacts look good.
> > Sigs are good, key is in KEYS.
> >
> > Following are blockers IMO:
> >
> > 1) I am getting the test failures below though, running under:
> >
> > Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> > Java version: 1.6.0_37
> > Java home:
> > /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> > Default locale: en_US, platform encoding: MacRoman
> > OS name: "mac os x" version: "10.7.5" arch: "x86_64" Family: "mac"
>
> this has already been observed by other people before, and it is most
> likely related to a buggy DNS server in your environment. The unit tests
> try resolve an invalid url (http://example.invalid), which seems to
> succeed in your case. You can test it yourself by typing the url in your
> browser.
>
> I am already in favor of changing the unit test to prevent such issues
> again in the future, but imho this is not blocking a release.
>
> > 2) There are missing @since tags for the methods added to the Email
> > class.
> >
> > Not a blocker, but should be fixed:
> >
> > 3) Release notes refer to obsolete Sun URLs.  These (sadly,
> > typically) redirect to pages of no real value in finding the
> > artifacts that they used to point to.  I would drop the URLs and
> > reference to Sun.
>
> I will fix the other things.
>
> Thanks,
>
> Thomas
>

Re: [VOTE] Release of commons-email-1.3 based on RC6

Posted by Thomas Neidhart <th...@gmail.com>.
On 12/16/2012 06:43 PM, Phil Steitz wrote:
> Artifacts look good.
> Sigs are good, key is in KEYS.
> 
> Following are blockers IMO:
> 
> 1) I am getting the test failures below though, running under:
> 
> Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> Java version: 1.6.0_37
> Java home:
> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x" version: "10.7.5" arch: "x86_64" Family: "mac"

this has already been observed by other people before, and it is most
likely related to a buggy DNS server in your environment. The unit tests
try resolve an invalid url (http://example.invalid), which seems to
succeed in your case. You can test it yourself by typing the url in your
browser.

I am already in favor of changing the unit test to prevent such issues
again in the future, but imho this is not blocking a release.

> 2) There are missing @since tags for the methods added to the Email
> class.
> 
> Not a blocker, but should be fixed:
> 
> 3) Release notes refer to obsolete Sun URLs.  These (sadly,
> typically) redirect to pages of no real value in finding the
> artifacts that they used to point to.  I would drop the URLs and
> reference to Sun.

I will fix the other things.

Thanks,

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release of commons-email-1.3 based on RC6

Posted by Phil Steitz <ph...@gmail.com>.
Artifacts look good.
Sigs are good, key is in KEYS.

Following are blockers IMO:

1) I am getting the test failures below though, running under:

Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
Java version: 1.6.0_37
Java home:
/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x" version: "10.7.5" arch: "x86_64" Family: "mac"

2) There are missing @since tags for the methods added to the Email
class.

Not a blocker, but should be fixed:

3) Release notes refer to obsolete Sun URLs.  These (sadly,
typically) redirect to pages of no real value in finding the
artifacts that they used to point to.  I would drop the URLs and
reference to Sun.

Test failures:

Running org.apache.commons.mail.HtmlEmailTest
Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.391 sec <<< FAILURE!
testEmbedUrl(org.apache.commons.mail.HtmlEmailTest)  Time elapsed:
237 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Should have thrown an exception
    at junit.framework.Assert.fail(Assert.java:57)
    at junit.framework.TestCase.fail(TestCase.java:227)
    at
org.apache.commons.mail.HtmlEmailTest.testEmbedUrl(HtmlEmailTest.java:181)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:176)
    at junit.framework.TestCase.runBare(TestCase.java:141)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
    at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
    at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
    at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
    at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
    at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

Running org.apache.commons.mail.ImageHtmlEmailTest
Tests run: 22, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
28.979 sec <<< FAILURE!
testEmbedUrl(org.apache.commons.mail.ImageHtmlEmailTest)  Time
elapsed: 125 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Should have thrown an exception
    at junit.framework.Assert.fail(Assert.java:57)
    at junit.framework.TestCase.fail(TestCase.java:227)
    at
org.apache.commons.mail.HtmlEmailTest.testEmbedUrl(HtmlEmailTest.java:181)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:176)
    at junit.framework.TestCase.runBare(TestCase.java:141)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
    at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
    at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
    at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
    at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
    at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

Running org.apache.commons.mail.InvalidAddressTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.002 sec
Running org.apache.commons.mail.InvalidInternetAddressTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.003 sec
Running org.apache.commons.mail.MultiPartEmailTest
Tests run: 11, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
0.25 sec <<< FAILURE!
testAttach3(org.apache.commons.mail.MultiPartEmailTest)  Time
elapsed: 109 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Should have thrown an exception
    at junit.framework.Assert.fail(Assert.java:57)
    at junit.framework.TestCase.fail(TestCase.java:227)
    at
org.apache.commons.mail.MultiPartEmailTest.testAttach3(MultiPartEmailTest.java:322)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:176)
    at junit.framework.TestCase.runBare(TestCase.java:141)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
    at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
    at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
    at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
    at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
    at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

testAttach(org.apache.commons.mail.MultiPartEmailTest)  Time
elapsed: 125 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Should have thrown an exception
    at junit.framework.Assert.fail(Assert.java:57)
    at junit.framework.TestCase.fail(TestCase.java:227)
    at
org.apache.commons.mail.MultiPartEmailTest.testAttach(MultiPartEmailTest.java:246)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at junit.framework.TestCase.runTest(TestCase.java:176)
    at junit.framework.TestCase.runBare(TestCase.java:141)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:255)
    at junit.framework.TestSuite.run(TestSuite.java:250)
    at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
    at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
    at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
    at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
    at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
    at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)



On 12/16/12 6:03 AM, Thomas Neidhart wrote:
> Hi,
>
> I would like to call a vote from commons-email-1.3 based on RC6.
>
> This release candidate has the following changes compared to RC5
>
> +) fixed Clirr errors by reverting the changes related to refactoring
>    of constants from Email to EmailConstants.
>
> The files:
>
> The artifacts are deployed to Nexus:
> https://repository.apache.org/content/repositories/orgapachecommons-031/org/apache/commons/commons-email/1.3/
>
> The tag:
> https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_RC6/
>
> The site:
> http://people.apache.org/builds/commons/email/1.3/RC6/
>
> Additional Notes:
>
> o the download page and api links to older releases only work on
>   the published site and will be corrected after release.
>
> Please take a look at the commons-email-1.3 artifacts and vote!
>
> ------------------------------------------------
> [ ] +1 release it.
> [ ] +0 go ahead; I don't care.
> [ ] -0 there are a few minor glitches: ...
> [ ] -1 no, do not release it because ...
> ------------------------------------------------
>
> Vote will remain open for at least 72 hours.
>
> Thanks in advance,
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release of commons-email-1.3 based on RC6

Posted by Oliver Heger <ol...@oliver-heger.de>.
Checked build with Java 1.5 under Windows 7. Artifacts and site look good.

+1

Oliver

Am 16.12.2012 15:03, schrieb Thomas Neidhart:
> Hi,
>
> I would like to call a vote from commons-email-1.3 based on RC6.
>
> This release candidate has the following changes compared to RC5
>
> +) fixed Clirr errors by reverting the changes related to refactoring
>     of constants from Email to EmailConstants.
>
> The files:
>
> The artifacts are deployed to Nexus:
> https://repository.apache.org/content/repositories/orgapachecommons-031/org/apache/commons/commons-email/1.3/
>
> The tag:
> https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_RC6/
>
> The site:
> http://people.apache.org/builds/commons/email/1.3/RC6/
>
> Additional Notes:
>
> o the download page and api links to older releases only work on
>    the published site and will be corrected after release.
>
> Please take a look at the commons-email-1.3 artifacts and vote!
>
> ------------------------------------------------
> [ ] +1 release it.
> [ ] +0 go ahead; I don't care.
> [ ] -0 there are a few minor glitches: ...
> [ ] -1 no, do not release it because ...
> ------------------------------------------------
>
> Vote will remain open for at least 72 hours.
>
> Thanks in advance,
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org