You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by stanlyDoge <gi...@git.apache.org> on 2018/03/08 10:04:54 UTC
[GitHub] activemq-artemis pull request #1940: ARTEMIS-1737 fix for inaccessible slave...
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1940
ARTEMIS-1737 fix for inaccessible slave console after failover
Can anybody review this? I will try to write some tests meanwhile. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis E1018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1940
----
commit 81d6328850b77b3d314aa64ea61a24bbb1baf055
Author: Stanislav Knot <sk...@...>
Date: 2018-03-08T10:03:37Z
ARTEMIS-1737 fix for inaccessible slave console after failover
----
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
@stanlyDoge nice test though!! What ever the fix worth making sure it gets added in :)
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
@clebertsuconic i assume you will PR your modifications before merge.
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
@michaelandrepearce will do.. I thought I would be able to do it tonight... I'm hitting another issue.. so it will be tomorrow.
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
@stanlyDoge its not just the console affected. the root cause of the issue you are seeing was that actually fail() method called prior to your change used to have the isExit flag to false, there are actually a few places that can be invoked as well, as such whilst the negative effect of this change that ive called out, is most visible with the console, there are more serious bits seen that also look like they're affected such as Network Pinger.
This really needs to have @clebertsuconic look over his original change, as it seems that it is what caused this, also others in my opinion. And any fix needs to not just care about the console.
---
[GitHub] activemq-artemis pull request #1940: ARTEMIS-1737 fix for inaccessible slave...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1940
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by stanlyDoge <gi...@git.apache.org>.
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
Yes, it is. I used this conf: https://pastebin.com/2G0c341X
If I am not wrong, restaring logic is implemented as [this](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java#L194).
I am not sure if it would be ok to iterate all ExternalComponents here and if it is web one, just start it again. What do you think?
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by stanlyDoge <gi...@git.apache.org>.
Github user stanlyDoge commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
Ah, I see. Yeah, it seem to be changed in [ARTEMIS-1440](https://issues.apache.org/jira/browse/ARTEMIS-1440). @clebertsuconic can you take a look?
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
Is this on fail back to master? With restart enabled?
If so shouldn’t the console be in the restarting logic with the other components?
---
[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1940
I'm running the testsuite... I will merge a modified patch.. thanks a lot @stanlyDoge
---