[jira] [Commented] (TAP5-2537) ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738647#comment-17738647 ] 

ASF subversion and git services commented on TAP5-2537:
-------------------------------------------------------

Commit 0b1437fcaa26c5401e29a0f0e36cec7d886aea73 in tapestry-5's branch refs/heads/TAP5-2741 from Volker Lamp
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0b1437fca ]

TAP5-2537: Added integration test to show this bug is fixed.

> ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2537
>                 URL: https://issues.apache.org/jira/browse/TAP5-2537
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: I D
>            Assignee: Volker Lamp
>            Priority: Major
>             Fix For: 5.4.1
>
>
> An IllegalStateException is thrown when calling ApplicationStateManagerImpl.getIfExists() on an invalid session. I would expect the method to catch the exception and return null in this case.
> Stack trace (top only):
> {code:java}
> - org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
>   - org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
>   - org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
>   - org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
>   - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
>   - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
>   - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)