Re: [PR] KAFKA-17316: Standard authorizer refactor [kafka]

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on PR #16779:
URL: https://github.com/apache/kafka/pull/16779#issuecomment-2344112120

   @cmccabe 
   You asked about why the StandardAuthorizerData was easier to test than the StandardAuthorizer.
   
   It is not that the StandardAuthorizerData is easier to test, it is that the interface for StandardAuthorizerData is different than the StandardAuthorizer.  The StandardAuthorizer does some work and then passed requests on to the StandardAuthorizerData to handle.  So the parameters are different for some methods.  This give us the opportunity to test the StandardAuthorizerData interface separate from the StandardAuthorizer.  In many cases it is probably possible to implement the StandardAuthorizerData than to start at the StandardAuthorizer level.  The Trie implementation is simply a replacement for the StandardAuthorizerData.
   
   The tests will now verify edge cases and corner cases for the StandardAuthorizerData that otherwise were not discovered until integration testing.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org