[jira] [Commented] (AIRFLOW-6528) disable W503 flake8 check (line break before binary operator)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012525#comment-17012525 ] 

ASF GitHub Bot commented on AIRFLOW-6528:
-----------------------------------------

dstandish commented on pull request #7124: [AIRFLOW-6528] disable flake8 W503 line break before binary operator
URL: https://github.com/apache/airflow/pull/7124
 
 
   Flake8's W503 rule says there should be no line break before binary operator.
   
   This rule is incompatible with black formatter, and is also in my opinion bad style.
   
   Status quo example with W503 check enabled:
   ```
       @property
       def sqlalchemy_scheme(self):
           """
           Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
           """
           return (
               self._sqlalchemy_scheme or
               self.connection_extra_lower.get('sqlalchemy_scheme') or
               self.DEFAULT_SQLALCHEMY_SCHEME
           )
   ```
   
   as required by black (W503 disabled)
   ```
       @property
       def sqlalchemy_scheme(self):
           """
           Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
           """
           return (
               self._sqlalchemy_scheme
               or self.connection_extra_lower.get('sqlalchemy_scheme')
               or self.DEFAULT_SQLALCHEMY_SCHEME
           )
   ```
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> disable W503 flake8 check (line break before binary operator)
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-6528
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6528
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: pre-commit
>    Affects Versions: 1.10.7
>            Reporter: Daniel Standish
>            Priority: Trivial
>
> Flake8's W503 rule says there should be no line break before binary operator.
> This rule is incompatible with black formatter, and is also in my opinion bad style.
> Status quo example with W503 check enabled:
> {code}
>     @property
>     def sqlalchemy_scheme(self):
>         """
>         Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
>         """
>         return (
>             self._sqlalchemy_scheme or
>             self.connection_extra_lower.get('sqlalchemy_scheme') or
>             self.DEFAULT_SQLALCHEMY_SCHEME
>         )
> {code}
> as required by black (W503 disabled)
> {code}
>     @property
>     def sqlalchemy_scheme(self):
>         """
>         Database provided in init if exists; otherwise, ``schema`` from ``Connection`` object.
>         """
>         return (
>             self._sqlalchemy_scheme
>             or self.connection_extra_lower.get('sqlalchemy_scheme')
>             or self.DEFAULT_SQLALCHEMY_SCHEME
>         )
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)