[jira] [Commented] (TEZ-3404) Remove blocking call for ATS domain creation from client side to AM

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414442#comment-15414442 ] 

Hitesh Shah commented on TEZ-3404:
----------------------------------

Comments: 

 - Why are we introducing new configs ( YARN_ATS_ACL_SESSION_VIEW_ACL, YARN_ATS_ACL_DAG_VIEW_ACL , etc ) for acls - dont they already exist? There are no docs on what these configs are for, whether this is internal only, user facing, etc. If they are constants to be used in a map, they do not belong in configs.

- any reason why the functionality to create domains is pulled out of the policy manager classes? Also, is there any difference between ATSV15HistoryACLPolicyManager and ATSHistoryACLPolicyManager now? Does the PolicyManager need to be a separate class i.e. does it have enough functionality to justify need or can it be bundled with the logger class itself now? 

- what happens if "createTimelineDomain(conf, true);" throws an error? Does the AM fail to startup? Do we still continue to publish events to ATS even though domain creation fails?

"ApplicationAttemptId appAttemptId = ApplicationAttemptId.newInstance(appContext.getApplicationID(), 1);" - not using the actual app attempt id? Any reason why? 




> Remove blocking call for ATS domain creation from client side to AM
> -------------------------------------------------------------------
>
>                 Key: TEZ-3404
>                 URL: https://issues.apache.org/jira/browse/TEZ-3404
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: TEZ-3404-WIP-01.patch
>
>
> Today, there is a blocking call for creating the domain on the client side which blocks hive query throughput. We need to move this to the AM and still retain the same security guarantees.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)