You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/10/22 09:39:49 UTC

[GitHub] [libcloud] Kami commented on pull request #1576: Fix LibcloudConnection Session timeout issue

Kami commented on pull request #1576:
URL: https://github.com/apache/libcloud/pull/1576#issuecomment-949458307


   After digging in some more and to be on the safe side, I decided to add some additional test cases / asserts (32653fe64a045f8c03d127544be86edc74dbfa74), since the one which was added in this PR (https://github.com/apache/libcloud/pull/1576/files#diff-3ad0002be7627437faad5c60d1fadd3674be25d07619a8c21e0f56942965381eR190) really just asserts that the ``timeout`` variable is set on the session object and not that the timeout is actually passed to the underlying requests ``send()`` method (which is what was not happening previously due to the code not passing that argument).
   
   I know another test case was also added in that PR, but that one verifies ConnectionTimeout whereas the one I added verifies ReadTimeout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org