You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/03/07 17:46:21 UTC
Review Request 57389: Discard/Save buttons for service configs are
always enabled if custom property is overridden with empty value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57389/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-20348
https://issues.apache.org/jira/browse/AMBARI-20348
Repository: ambari
Description
-------
# STR
1. Create custom property for any service
2. Create override for this property (override value should be empty)
3. Save changes
# Result
Discard and Save button on configs page of the mentioned service are always enabled.
Diffs
-----
ambari-web/app/utils/config.js 28881bb
ambari-web/test/utils/config_test.js f418614
Diff: https://reviews.apache.org/r/57389/diff/1/
Testing
-------
20577 passing (20s)
153 pending
Thanks,
Andrii Babiichuk
Re: Review Request 57389: Discard/Save buttons for service configs are
always enabled if custom property is overridden with empty value
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57389/#review168159
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u041c\u0430\u0440\u0442 7, 2017, 5:46 \u043f.\u043f., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57389/
> -----------------------------------------------------------
>
> (Updated \u041c\u0430\u0440\u0442 7, 2017, 5:46 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20348
> https://issues.apache.org/jira/browse/AMBARI-20348
>
>
> Repository: ambari
>
>
> Description
> -------
>
> # STR
> 1. Create custom property for any service
> 2. Create override for this property (override value should be empty)
> 3. Save changes
>
> # Result
> Discard and Save button on configs page of the mentioned service are always enabled.
>
>
> Diffs
> -----
>
> ambari-web/app/utils/config.js 28881bb
> ambari-web/test/utils/config_test.js f418614
>
>
> Diff: https://reviews.apache.org/r/57389/diff/1/
>
>
> Testing
> -------
>
> 20577 passing (20s)
> 153 pending
>
>
> Thanks,
>
> Andrii Babiichuk
>
>