You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benjamin Black (JIRA)" <ji...@apache.org> on 2010/05/11 18:38:42 UTC

[jira] Created: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Thrift interface call to query whether all live nodes agree on the schema id
----------------------------------------------------------------------------

                 Key: CASSANDRA-1075
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
             Project: Cassandra
          Issue Type: New Feature
          Components: Core
            Reporter: Benjamin Black
            Priority: Minor


Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment: 0001-service-call-to-check-for-schema-agreement.patch
                0002-modify-system_-methods-to-return-UUID.patch

Updates based on feedback.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869092#action_12869092 ] 

Gary Dusbabek commented on CASSANDRA-1075:
------------------------------------------

> why not just use DD.getRpcTimeout? feels like trying to be too clever.

Wouldn't the client timeout on the call rather than get an actual result from the server?  This doesn't seem useful; I think a bit of helpfulness is warranted.

> ...return value should be map<version, list<endpoints>> ...a map of size 1 would be agreement.  What do you think?

How would we indicate the nodes that didn't respond (indicating disagreement)?  I think that a return type like that map overcomplicate what should be a simple yes-or-no question.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869197#action_12869197 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

good catch, but synchronizedmap doesn't use itself as the mutex, so this still doesn't fix the race of a new entry being added to versions (by a late reply) after it starts computing results

replacing all uses of versions after ackedhosts is created, w/ ackedhosts, would fix everything i think

then versions itself should be a CHM or NBHM just as a best practice instead of SM

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869012#action_12869012 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

(+1 on 02)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869675#action_12869675 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

+1 on these patches

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment: 0001-service-call-to-check-for-schema-agreement.patch
                0002-modify-system_-methods-to-return-UUID.patch

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment:     (was: 0002-modify-system_-methods-to-return-UUID.patch)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment: 0001-service-call-to-check-for-schema-agreement.patch
                0002-modify-system_-methods-to-return-UUID.patch

synchronizedmap does use itself for the mutex.  I guess there's no point of locking for reads though.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869174#action_12869174 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

+            assert missingHosts.size() > 0;

Shouldn't it be empty if everyone replies?


> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866204#action_12866204 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

looks like we should also update the system_add_* methods to return the migration_id created

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869011#action_12869011 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

on 01,

minor points:

Math.max(DatabaseDescriptor.getRpcTimeout()-1000, 500)

why not just use DD.getRpcTimeout?  feels like trying to be too clever.

+        catch (InterruptedException ex) 
+        {
+        }

let's throw assertionerror for these.

Finally, the .info logs feel like they should be .debug (we can always enable INFO for StorageProxy at runtime).  But you're right that people will want this info, which makes me think we should not make them dig through logs but instead the return value should be map<version, list<endpoints>>, that is, for each version list which endpoints had it.  (Missing endpoints could have '' version or possibly null.)  So a map of size 1 would be agreement.

What do you think?

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment: 0001-service-call-to-check-for-schema-agreement.patch

Fixes race on versions.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment:     (was: 0002-modify-system_-methods-to-return-UUID.patch)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1075:
--------------------------------------

             Assignee: Gary Dusbabek
        Fix Version/s: 0.7
    Affects Version/s: 0.7

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869673#action_12869673 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

SM says

        final Object      mutex;	// Object on which to synchronize


> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment:     (was: 0001-service-call-to-check-for-schema-agreement.patch)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment:     (was: 0001-service-call-to-check-for-schema-agreement.patch)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869120#action_12869120 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

> Wouldn't the client timeout on the call

No, clients never timeout.  rpctimeout is just "how long should node X wait for node Y."

> How would we indicate the nodes that didn't respond

Use null or ''.

> I think that a return type like that map overcomplicates it

A client library can always simplify to "return method().size() == 1" but you can't go the other direction.  "look at the log to figure out why it's false" doesn't feel good to me.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869983#action_12869983 ] 

Hudson commented on CASSANDRA-1075:
-----------------------------------

Integrated in Cassandra #442 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/442/])
    modify system_* methods to return UUID. patch by gdusbabek, reviewed by jbellis. CASSANDRA-1075
service call to check for schema agreement. patch by gdusbabek, reviewed by jbellis. CASSANDRA-1075


> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869182#action_12869182 ] 

Gary Dusbabek commented on CASSANDRA-1075:
------------------------------------------

yes, I check for that in the conditional before the assert.  This is me being paranoid because having an additional key in the map, even if it points no zero hosts, would indicase disagreement falsely.

It looks like there is a race condition on versions between the 'if (versions.size()...) and 'missingHosts.removeAll(versions.keySet());' that needs to be addressed anyway.

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1075:
-------------------------------------

    Attachment:     (was: 0001-service-call-to-check-for-schema-agreement.patch)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1075) Thrift interface call to query whether all live nodes agree on the schema id

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869716#action_12869716 ] 

Jonathan Ellis commented on CASSANDRA-1075:
-------------------------------------------

(Gary points out that later SM.mutex = this)

> Thrift interface call to query whether all live nodes agree on the schema id
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1075
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.7
>            Reporter: Benjamin Black
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-service-call-to-check-for-schema-agreement.patch, 0002-modify-system_-methods-to-return-UUID.patch
>
>
> Schema changes via the Thrift interface reach all nodes in a cluster at indeterminate times.  It would be extremely useful to be able to query, via API, a single node in the cluster and discover the current state of a transition to determine if all live nodes agree on the schema.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.