You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2018/03/26 14:44:26 UTC

[whimsy] branch master updated: indicate whether or not there were any responses to feedback email

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8193448  indicate whether or not there were any responses to feedback email
8193448 is described below

commit 8193448ce1b264dfe92f33fca8df0717858d7265
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Mon Mar 26 10:43:46 2018 -0400

    indicate whether or not there were any responses to feedback email
---
 www/board/agenda/views/app.js.rb                   |  1 +
 .../agenda/views/elements/additional-info.js.rb    | 25 ++++++++++++++++++++--
 www/board/agenda/views/models/responses.js.rb      | 22 +++++++++++++++++++
 3 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/www/board/agenda/views/app.js.rb b/www/board/agenda/views/app.js.rb
index 9efcb13..b7ac8e0 100644
--- a/www/board/agenda/views/app.js.rb
+++ b/www/board/agenda/views/app.js.rb
@@ -69,6 +69,7 @@ require_relative 'models/minutes'
 require_relative 'models/chat'
 require_relative 'models/jira'
 require_relative 'models/pending'
+require_relative 'models/responses'
 require_relative 'models/user'
 require_relative 'models/posted'
 require_relative 'models/comments'
diff --git a/www/board/agenda/views/elements/additional-info.js.rb b/www/board/agenda/views/elements/additional-info.js.rb
index 3f711f7..81662e5 100644
--- a/www/board/agenda/views/elements/additional-info.js.rb
+++ b/www/board/agenda/views/elements/additional-info.js.rb
@@ -89,7 +89,9 @@ class AdditionalInfo < Vue
             _span "\u2022 "
             _a date.gsub('_', '-'),
               href: HistoricalComments.link(date, @@item.title)
-            _span ': '
+
+            link = nil
+
 
             # link to mail archive for feedback thread
             if date > '2016_04' # when feedback emails were first started
@@ -97,7 +99,26 @@ class AdditionalInfo < Vue
               dfr = date.gsub('_', '-')
               dto = Date.new(Date.now()).toISOString()[0...10]
 
-              _a '(thread)', 
+              if date > '2017_11' # when board was no longer copied on the 
+                                  # initial email
+
+               if Responses.find(dfr, @@item.title)
+                link = '(responses)'
+               elsif Responses.loading
+                link = '(loading)'
+               else
+                link = '(no responses)'
+               end
+
+              else
+                link = '(thread)'
+              end
+            end
+
+            if link
+              _span ': '
+
+              _a link,
                 href: 'https://lists.apache.org/list.html?board@apache.org&' +
                   "d=dfr=#{dfr}|dto=#{dto}&header_subject=" +
                   "'Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report'"
diff --git a/www/board/agenda/views/models/responses.js.rb b/www/board/agenda/views/models/responses.js.rb
new file mode 100644
index 0000000..64c84fc
--- /dev/null
+++ b/www/board/agenda/views/models/responses.js.rb
@@ -0,0 +1,22 @@
+#
+# Fetch, retain, and query the list of feedback responses on board@
+#
+
+class Responses
+  Vue.util.defineReactive @@list, nil
+
+  def self.loading
+    @@list and @@list.keys().empty?
+  end
+
+  def self.find(date, name)
+    if @@list
+      return @@list[date] and @@list[date].include? name
+    else
+      @@list = {}
+      JSONStorage.fetch 'responses' do |list|
+        @@list = list
+      end
+    end
+  end
+end

-- 
To stop receiving notification emails like this one, please contact
rubys@apache.org.