You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ul...@apache.org on 2022/02/18 01:30:33 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #1926] Remove useless constants in Constants

This is an automated email from the ASF dual-hosted git repository.

ulyssesyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 6403224  [KYUUBI #1926] Remove useless constants in Constants
6403224 is described below

commit 6403224199d8cedcad9c8e0d98e2ff8be14c7062
Author: yanghua <ya...@gmail.com>
AuthorDate: Fri Feb 18 09:30:18 2022 +0800

    [KYUUBI #1926] Remove useless constants in Constants
    
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1927 from yanghua/KYUUBI-1926.
    
    Closes #1926
    
    3e82abb4 [yanghua] [KYUUBI #1926] Remove useless constants in Constants
    
    Authored-by: yanghua <ya...@gmail.com>
    Signed-off-by: ulysses-you <ul...@apache.org>
---
 .../kyuubi/engine/flink/result/Constants.java      | 31 ----------------------
 1 file changed, 31 deletions(-)

diff --git a/externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/result/Constants.java b/externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/result/Constants.java
index 3c1f1ab..889bcf9 100644
--- a/externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/result/Constants.java
+++ b/externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/result/Constants.java
@@ -21,39 +21,8 @@ package org.apache.kyuubi.engine.flink.result;
 /** Constant column names. */
 public class Constants {
 
-  // for statement execution
-  public static final String JOB_ID = "job_id";
-
-  // for results with SUCCESS result kind
-  public static final String RESULT = "result";
-  public static final String OK = "OK";
-
-  public static final String SHOW_MODULES_RESULT = "modules";
-
-  public static final String SHOW_CURRENT_CATALOG_RESULT = "catalog";
-
-  public static final String SHOW_CURRENT_DATABASE_RESULT = "database";
-
-  public static final String SHOW_DATABASES_RESULT = "databases";
-
-  public static final String SHOW_FUNCTIONS_RESULT = "functions";
-
-  public static final String EXPLAIN_RESULT = "explanation";
-
-  public static final String DESCRIBE_NAME = "name";
-  public static final String DESCRIBE_TYPE = "type";
-  public static final String DESCRIBE_NULL = "null";
-  public static final String DESCRIBE_KEY = "key";
-  public static final String DESCRIBE_COMPUTED_COLUMN = "computed_column";
-  public static final String DESCRIBE_WATERMARK = "watermark";
-
   public static final String SHOW_TABLES_RESULT = "tables";
 
-  public static final String SHOW_VIEWS_RESULT = "views";
-
-  public static final String SET_KEY = "key";
-  public static final String SET_VALUE = "value";
-
   public static final String TABLE_TYPE = "TABLE";
   public static final String VIEW_TYPE = "VIEW";