You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/06 11:33:44 UTC
[GitHub] [activemq-artemis] CNNJYB opened a new pull request #3435: ARTEMIS-3105 large message file not closed on backup side
CNNJYB opened a new pull request #3435:
URL: https://github.com/apache/activemq-artemis/pull/3435
We send a large number of large messages to the cluster, on the backup side, we found error message of too many open files.
We think that large message is released on live side but not released on the backup side, when receive the last chunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3435: ARTEMIS-3105 large message file not closed on backup side
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3435:
URL: https://github.com/apache/activemq-artemis/pull/3435#discussion_r571452013
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLargeMessageEndMessage.java
##########
@@ -57,6 +64,7 @@ public void decodeRest(final ActiveMQBuffer buffer) {
if (buffer.readableBytes() >= DataConstants.SIZE_LONG) {
pendingRecordId = buffer.readLong();
}
+ isDelete = buffer.readBoolean();
Review comment:
can you check hasRemaining() on the buffer here, and return false by default?
We intend to keep live and replica the same version, but users do weird things... just in case please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3435: ARTEMIS-3105 large message file not closed on backup side
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3435:
URL: https://github.com/apache/activemq-artemis/pull/3435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3435: ARTEMIS-3105 large message file not closed on backup side
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3435:
URL: https://github.com/apache/activemq-artemis/pull/3435#issuecomment-774499282
LGTM.. only one small request on verifying the buffer having available bytes.. other than that I will run the whole test suite on Monday and if it's good I will merge it (after your amend please?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org