[GitHub] [calcite] tanclary commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

["tanclary (via GitHub)" <gi...@apache.org>]

tanclary commented on code in PR #3245:
URL: https://github.com/apache/calcite/pull/3245#discussion_r1218556248


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -7335,9 +7336,13 @@ SqlNode StandardFloorCeilOptions(Span s, boolean floorFlag) :
         }
     )?
     <RPAREN> {
-        SqlOperator op = floorFlag
-            ? SqlStdOperatorTable.FLOOR
-            : SqlStdOperatorTable.CEIL;
+        SqlOperator op;
+        boolean isBigQuery = this.conformance.semantics() == SqlLibrary.BIG_QUERY;

Review Comment:
   look at way to make more scaleable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org