You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Christian Will (JIRA)" <xe...@xml.apache.org> on 2005/03/07 10:10:52 UTC
[jira] Created: (XERCESC-1370) Performance: XMLReader class define getter methods const
Performance: XMLReader class define getter methods const
---------------------------------------------------------
Key: XERCESC-1370
URL: http://issues.apache.org/jira/browse/XERCESC-1370
Project: Xerces-C++
Type: Improvement
Components: Miscellaneous
Versions: 2.6.0
Environment: all
Reporter: Christian Will
Priority: Minor
Attachments: XMLReader.cpp.patch, XMLReader.hpp.patch
Hi,
we should define these functions as constant, that offers the compiler more optimization.
bool isAllSpaces(...) const;
bool containsWhiteSpace(...) const;
bool isXMLLetter(const XMLCh toCheck) const;
bool isFirstNameChar(const XMLCh toCheck) const;
bool isNameChar(const XMLCh toCheck) const;
bool isPlainContentChar(const XMLCh toCheck) const;
bool isSpecialStartTagChar(const XMLCh toCheck) const;
bool isXMLChar(const XMLCh toCheck) const;
bool isWhitespace(const XMLCh toCheck) const;
bool isControlChar(const XMLCh toCheck) const;
bool isPublicIdChar(const XMLCh toCheck) const;
I attached patch files.
Regards,
Christian Will
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org
[jira] Resolved: (XERCESC-1370) Performance: XMLReader class define getter methods const
Posted by "cargilld (JIRA)" <xe...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XERCESC-1370?page=history ]
cargilld resolved XERCESC-1370:
-------------------------------
Resolution: Fixed
Hi Christian,
I checked in your patch. Can you please verify? Thanks.
David
> Performance: XMLReader class define getter methods const
> --------------------------------------------------------
>
> Key: XERCESC-1370
> URL: http://issues.apache.org/jira/browse/XERCESC-1370
> Project: Xerces-C++
> Type: Improvement
> Components: Miscellaneous
> Versions: 2.6.0
> Environment: all
> Reporter: Christian Will
> Priority: Minor
> Attachments: XMLReader.cpp.patch, XMLReader.hpp.patch
>
> Hi,
> we should define these functions as constant, that offers the compiler more optimization.
> bool isAllSpaces(...) const;
> bool containsWhiteSpace(...) const;
> bool isXMLLetter(const XMLCh toCheck) const;
> bool isFirstNameChar(const XMLCh toCheck) const;
> bool isNameChar(const XMLCh toCheck) const;
> bool isPlainContentChar(const XMLCh toCheck) const;
> bool isSpecialStartTagChar(const XMLCh toCheck) const;
> bool isXMLChar(const XMLCh toCheck) const;
> bool isWhitespace(const XMLCh toCheck) const;
> bool isControlChar(const XMLCh toCheck) const;
> bool isPublicIdChar(const XMLCh toCheck) const;
> I attached patch files.
> Regards,
> Christian Will
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org
[jira] Closed: (XERCESC-1370) Performance: XMLReader class define getter methods const
Posted by "cargilld (JIRA)" <xe...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XERCESC-1370?page=history ]
cargilld closed XERCESC-1370:
-----------------------------
Closing as changes have been verified.
> Performance: XMLReader class define getter methods const
> --------------------------------------------------------
>
> Key: XERCESC-1370
> URL: http://issues.apache.org/jira/browse/XERCESC-1370
> Project: Xerces-C++
> Type: Improvement
> Components: Miscellaneous
> Versions: 2.6.0
> Environment: all
> Reporter: Christian Will
> Priority: Minor
> Attachments: XMLReader.cpp.patch, XMLReader.hpp.patch
>
> Hi,
> we should define these functions as constant, that offers the compiler more optimization.
> bool isAllSpaces(...) const;
> bool containsWhiteSpace(...) const;
> bool isXMLLetter(const XMLCh toCheck) const;
> bool isFirstNameChar(const XMLCh toCheck) const;
> bool isNameChar(const XMLCh toCheck) const;
> bool isPlainContentChar(const XMLCh toCheck) const;
> bool isSpecialStartTagChar(const XMLCh toCheck) const;
> bool isXMLChar(const XMLCh toCheck) const;
> bool isWhitespace(const XMLCh toCheck) const;
> bool isControlChar(const XMLCh toCheck) const;
> bool isPublicIdChar(const XMLCh toCheck) const;
> I attached patch files.
> Regards,
> Christian Will
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org
[jira] Commented: (XERCESC-1370) Performance: XMLReader class define getter methods const
Posted by "Christian Will (JIRA)" <xe...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XERCESC-1370?page=comments#action_61416 ]
Christian Will commented on XERCESC-1370:
-----------------------------------------
Hi David,
it looks good.
Thanks,
Christian
> Performance: XMLReader class define getter methods const
> --------------------------------------------------------
>
> Key: XERCESC-1370
> URL: http://issues.apache.org/jira/browse/XERCESC-1370
> Project: Xerces-C++
> Type: Improvement
> Components: Miscellaneous
> Versions: 2.6.0
> Environment: all
> Reporter: Christian Will
> Priority: Minor
> Attachments: XMLReader.cpp.patch, XMLReader.hpp.patch
>
> Hi,
> we should define these functions as constant, that offers the compiler more optimization.
> bool isAllSpaces(...) const;
> bool containsWhiteSpace(...) const;
> bool isXMLLetter(const XMLCh toCheck) const;
> bool isFirstNameChar(const XMLCh toCheck) const;
> bool isNameChar(const XMLCh toCheck) const;
> bool isPlainContentChar(const XMLCh toCheck) const;
> bool isSpecialStartTagChar(const XMLCh toCheck) const;
> bool isXMLChar(const XMLCh toCheck) const;
> bool isWhitespace(const XMLCh toCheck) const;
> bool isControlChar(const XMLCh toCheck) const;
> bool isPublicIdChar(const XMLCh toCheck) const;
> I attached patch files.
> Regards,
> Christian Will
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org
[jira] Updated: (XERCESC-1370) Performance: XMLReader class define getter methods const
Posted by "Christian Will (JIRA)" <xe...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XERCESC-1370?page=history ]
Christian Will updated XERCESC-1370:
------------------------------------
Attachment: XMLReader.cpp.patch
XMLReader.hpp.patch
> Performance: XMLReader class define getter methods const
> --------------------------------------------------------
>
> Key: XERCESC-1370
> URL: http://issues.apache.org/jira/browse/XERCESC-1370
> Project: Xerces-C++
> Type: Improvement
> Components: Miscellaneous
> Versions: 2.6.0
> Environment: all
> Reporter: Christian Will
> Priority: Minor
> Attachments: XMLReader.cpp.patch, XMLReader.hpp.patch
>
> Hi,
> we should define these functions as constant, that offers the compiler more optimization.
> bool isAllSpaces(...) const;
> bool containsWhiteSpace(...) const;
> bool isXMLLetter(const XMLCh toCheck) const;
> bool isFirstNameChar(const XMLCh toCheck) const;
> bool isNameChar(const XMLCh toCheck) const;
> bool isPlainContentChar(const XMLCh toCheck) const;
> bool isSpecialStartTagChar(const XMLCh toCheck) const;
> bool isXMLChar(const XMLCh toCheck) const;
> bool isWhitespace(const XMLCh toCheck) const;
> bool isControlChar(const XMLCh toCheck) const;
> bool isPublicIdChar(const XMLCh toCheck) const;
> I attached patch files.
> Regards,
> Christian Will
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org