[GitHub] sandeep-krishnamurthy commented on a change in pull request #12572: Make Gluon download function to be atomic

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #12572: Make Gluon download function to be atomic
URL: https://github.com/apache/incubator-mxnet/pull/12572#discussion_r219033278
 
 

 ##########
 File path: python/mxnet/gluon/utils.py
 ##########
 @@ -195,6 +197,42 @@ def check_sha1(filename, sha1_hash):
     return sha1.hexdigest() == sha1_hash
 
 
+if not sys.platform.startswith('win32'):
+    # refer to https://github.com/untitaker/python-atomicwrites
+    def _replace_atomic(src, dst):
+        """Implement atomic os.replace with linux and OSX. Internal use only"""
+        try:
+            os.rename(src, dst)
+        except OSError:
+            raise OSError('os.rename failed. Might be wrong source path.')
 
 Review comment:
   Error message should be more user friendly. Something like - "Moving downloaded temp file - %s, to %s failed. Please retry the download.".format(src, dst) .
   Or something similar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services