You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/13 14:47:45 UTC

[GitHub] marcoabreu closed pull request #11226: Fix build.py in docker for osx

marcoabreu closed pull request #11226: Fix build.py in docker for osx
URL: https://github.com/apache/incubator-mxnet/pull/11226
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ci/build.py b/ci/build.py
index 4473f54210a..35f8b478abf 100755
--- a/ci/build.py
+++ b/ci/build.py
@@ -34,6 +34,7 @@
 import subprocess
 import sys
 import tempfile
+import platform
 from copy import deepcopy
 from itertools import chain
 from subprocess import call, check_call
@@ -121,11 +122,16 @@ def buildir() -> str:
 
 
 def default_ccache_dir() -> str:
+    # Share ccache across containers
     if 'CCACHE_DIR' in os.environ:
         ccache_dir = os.path.realpath(os.environ['CCACHE_DIR'])
         os.makedirs(ccache_dir, exist_ok=True)
-        return ccache_dirpython
-    # Share ccache across containers
+        return ccache_dir
+    # In osx tmpdir is not mountable by default
+    if platform.system() == 'Darwin':
+        ccache_dir = "/tmp/_mxnet_ccache"
+        os.makedirs(ccache_dir, exist_ok=True)
+        return ccache_dir
     return os.path.join(tempfile.gettempdir(), "ci_ccache")
 
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services