You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/06 06:32:14 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #553: [SCB-1301]Change the startup process of the syncer's services for subsequent cluster management

tianxiaoliang commented on a change in pull request #553: [SCB-1301]Change the startup process of the syncer's services for subsequent cluster management
URL: https://github.com/apache/servicecomb-service-center/pull/553#discussion_r291036508
 
 

 ##########
 File path: syncer/serf/agent.go
 ##########
 @@ -54,19 +52,12 @@ func Create(conf *Config, logOutput io.Writer) (*Agent, error) {
 }
 
 // Start agent
-func (a *Agent) Start(ctx context.Context) {
 
 Review comment:
   why delete context management

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services