[GitHub] [cxf] steingebein edited a comment on issue #603: [CXF-8161] fix memory leak and thread leak in JMSDestination

[GitBox <gi...@apache.org>]

steingebein edited a comment on issue #603: [CXF-8161] fix memory leak and thread leak in JMSDestination
URL: https://github.com/apache/cxf/pull/603#issuecomment-565980488
 
 
   Hi @reta, thank you for review & finish this pull request.
   
   `running = false;` makes the poller threads stopping/failing faster, so I think that's better.
   
   Your test changes: my test case was intended to test multiple poller-threads failing, so they call `handleException` parallel. In your test case the error handling runs not parallel, because there's only one poller thread. If you remove `sychronized` and my changes in `ExceptionListener`, your test will not fail.
   I created another branch with following changes to the test case:
   - `concurrentConsumer` is set 10
   - `FaultyConnection` will fail 5 times (more poller-threads will fail)
   - verify that there was only one call to restartConnection() 
   
   See  [CXF-8161 test case with parallel error handling](https://github.com/steingebein/cxf/commit/0dbf6c046b2b321d03474003104beae732c5ebf4)
   
   If you like these changes I can create another pull request.
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services