You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/22 15:14:42 UTC
[GitHub] [airflow] OmairK opened a new pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
OmairK opened a new pull request #9476:
URL: https://github.com/apache/airflow/pull/9476
Dag Runs are immutable and clear_task_instances can be used to modify the Dag Runs table.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-648026550
> This code looks fine. @mik-laj do you know if there was a reason the spec included the ability to update dag runs via PATCH?
@mik-laj himself suggested to remove this endpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-648121471
@jhtimmins I can't find fields that can be modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-649363748
@OmairK Can you do a rebase? I would like to merge this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] OmairK commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
OmairK commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-649463787
> @OmairK Can you do a rebase? I would like to merge this change.
@mik-laj I did the rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-647790169
Looks like this is failing static checks. I recommend running [pre-commit](https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks) checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins removed a comment on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
jhtimmins removed a comment on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-647790169
Looks like this is failing static checks. I recommend running [pre-commit](https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks) checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #9476:
URL: https://github.com/apache/airflow/pull/9476#issuecomment-647782731
This code looks fine. @mik-laj do you know if there was a reason the spec included the ability to update dag runs via PATCH?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9476: Remove PATCH /dags/{dag_id}/dagRuns/{dag_run_id} endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9476:
URL: https://github.com/apache/airflow/pull/9476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org